Posted by adam_b on April 14, 2009 at 1:12pm
5 followers
| Project: | Storm |
| Version: | 6.x-1.x-dev |
| Component: | Miscellaneous |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
I create a person and save the record - but although the People list page says "Person XXX XXX has been created", there are no people listed.
The people do appear in the "Add a new team member" page pulldown, so the records have been created - but they're not being listed.
Comments
#1
I cannot reproduce this error. What happens if you refresh the page?
Please could you also check which version you are using - the issue is marked 1.9 - did you mean 1.21? (the version drop-down doesn't keep them in the right order once releases go past 9...).
#2
Sorry, should be v6.x-1.21 as you suggest.
But refreshing the page doesn't help - nor does clearing the browser or Drupal caches. I tried making people who were/weren't linked to Drupal users - didn't make any difference.
#3
OK lets just check we're doing exactly the same thing:
I'm doing this as we speak on http://storm.beta-web.co.uk/storm - although this is the dev version, there have only been documentation and formatting changes between this and 1.21 so far.
1) At http://storm.beta-web.co.uk/storm/people we click on the + sign
2) At http://storm.beta-web.co.uk/node/add/stormperson?destination=storm%2Fpeople and fill out form, click save.
3) Back at http://storm.beta-web.co.uk/storm/people, the person seems to be listed.
Are we on the same lines?
It's just occured to me, i'm on the user/1 account, which may be one difference.
#4
Doh!
The filter on the People page was defaulting to display from another organisation, under which I hadn't entered any people. Changing it to All fixed it.
Any chance of making All the default? and maybe making the filter open rather than collapsed by default?
Sorry to take your time :)
#5
Changing status to a feature request.
#6
Just +1 for this feature request. this has been confusing ;)
#7
I don't want to default the filter to open because then i'd want to do it for all Storm listings, and some filters take up quite a bit of screen space.
Therefore instead i'll add a line "filtered by xxxx and yyyy" underneath the filter to make it clearer.
#8
Renaming to show the intended solution
#9
#540366: Timetrackings list is missing times marked as duplicate of this issue.
#10
I've created a patch, as a demonstration, against tickets which shows
Filtered by xxxx, yyyy, zzzz
#11
Changing status
#12
- It always seems to say 'Filtered by Date' even when no date settings are selected.
- Not sure that items per page is necessary - that's more of a view setting than a filter.
Minor - a bit of themeing - it'd be good to put it all in bold, and have italics for the field names.
#13
Okay fixed date issue and updated patch and implemented on my test site
URL: storm.ctscomputing.com
Username: stormtest
Password: Storm-Test
I put the items per page there just have something there when nothing was filtered and also because I thought technically it was a filter but I can remove if you want?
Theming - nice idea and can do, but how about replace the link on the fieldset expander with the current filter settings? It would save page space.
Thanks
Mark
#14
Changing status
#15
How about:
- First sentence: Either: "Not filtered." or "Filtered by xxx, yyy, zzz."
- Second sentence: "xxx items per page."
That way, it'd be clear that its not a filter persay, but would be displayed so that people wouldn't have to open the fieldset to check. It'd also help when there were no filters in place.
I'm all for putting it as the fieldset label - that's a good idea.
#16
I don't think the fieldset label can support multiple lines, so I've seperated the filter and items per page by a |
Patch attached
#17
Looks good - although when it goes in i'll add a colon to make "Items per page: 10" just to have a bit better grammar!
Thanks.
#18
Hello @Magnity
Noticed this one didn't make it in to latest release or dev.
Is there anymore work to be done on this one?
Thanks
Mark
#19
Hi Mark - no, this is on the way in.
It didn't make it into the snapshot because i was trying to get bugs sorted only - this wasn't as effective as i intended admittedly though.
I ran out of time to commit it to dev last night.
#20
no probs, just checking in case more work was needed.
Cheers
Mark
#21
Committed for tickets and timetrackings. I'll continue with this for the other modules tomorrow.
A minor note: t() should not be passed variables as their arguments, but instead have t() put around the particular inputs, then when they are combined, placeholders used to represent the variables that are being passed in. This is because the t() function is used to find strings for translation.
Attached is the patch used for timetrackings for me to work from as i've made a few changes.
#22
Committed for all Storm modules.
#23
Automatically closed -- issue fixed for 2 weeks with no activity.