Map MailChimp input to Drupal FormAPI (patch attached)

jchatard - April 14, 2009 - 13:29
Project:MailChimp
Version:6.x-2.x-dev
Component:Code
Category:task
Priority:normal
Assigned:Unassigned
Status:closed
Description

Hi all,

Here is a small patch that maps Dropdown et Radios from MailChimp to Drupal FormAPI. With that newsletter subscription form displays nice widgets.

i.e. : no more textfield input when telling MailChimp form builder to render a dropdown.

I also added a test condition so that hidden fields (from MailChimp) renders hidden fields in Drupal.

Unfortunaltely, the MailChimp date input can't be supported easily for now.

Last, I just made a small modification to form validate, which was letting me subscribe to a newsletter even if I did not checked the box (the small '1' added).

Look at the patch.

Thank you guys!
Jérémy

AttachmentSize
mailchimp-Drupal-FormAPI-6.diff3.05 KB

#1

jchatard - April 14, 2009 - 13:29
Title:Map MailChimp input to Drupal FormAPI (path attached)» Map MailChimp input to Drupal FormAPI (patch attached)

grr, patch just takes a 'C'.

#2

LouBabe - August 22, 2009 - 08:32
Version:6.x-1.x-dev» 6.x-2.x-dev
Status:active» needs review

Nice patch, applied. Needs some review. Also might want to add an switch for dates. Note applied to 6.x-2.x-dev

#3

LouBabe - September 14, 2009 - 16:35
Status:needs review» fixed

#4

System Message - September 28, 2009 - 16:40
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.