Uploads losing list state on submit.. initial insert only

Doesn't work. Now, uploads can never be listed.

I'm not sure I see a problem with CVS head. When I attach a file and select for it not to be listed, it doesn't show up and this is prior to applying your patch. I cant seem to produce the problem.

Try changing list *after* the node has been submitted.

I can reproduce this on beta2 and HEAD, and Junyor, that is not a solution, that is the problem dopry has raised.

I will try the patch at some point, once I've finished wrestling with these damn resizable text-areas. >:|

Patch works great, at least for beta2.

I wasn't posting a solution, I was posting about how to reproduce a bug with this patch. Let me be more verbose:

Reproduction:
1) Submit a node with the list attribute of a file disabled
2) Edit the node
3) Enable list attribute of the file
4) Submit the node

Expected result:
1) The file should now be listed when viewing the node
2) The list attribute should be checked when the node is edited

Actual result:
1) The file is not listed when viewing the node
2) The list attribute is not checked when the node is edited

The problem also appears if the list attribute was initially enabled and you try to disable it.

In other words, with this patch, it's impossible to change the list attribute after the node has been submitted.

It looks like that's a problem when creating new revisions. With revisions disabled, this patch works as advertised. Note that the problem I'm seeing happens without this patch too. Thus, this patch fixes a bug, though other bugs exist.

Tested with and without revisions. Works as advertised.

Committed to HEAD. Thanks.