I'd like to contribute patches to this module against the API module and also to contribute more code like the geonames_tools.module. However, the mixed use of tabs and spaces and inconsistent indentation makes this more difficult. Here's a patch that brings the DRUPAL-6--1 code branch up to the "minor" threshold of Coder.module.

CommentFileSizeAuthor
geonames-code-standards.patch67.93 KBAnonymous (not verified)

Comments

lyricnz’s picture

lyricnz commented
Status: Active » Fixed

I've reviewed this manually, but not tested it, and it looks okay. I've applied it, on the assumption that you've already tested it (in particular the use of drupal string functions instead of php string functions).

Anonymous’s picture

Anonymous (not verified) commented

So far so good for my usage. I'll keep an eye on the issue queue in case someone discovers any problems.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.