It may seem overly obvious, but the "Vocabs to use.:" field should be a selector instead of a text box - right now there's no indication as to whether you should enter the vocabulary's name or ID.

Comments

yan’s picture

dww’s picture

Category: feature » bug

Coupled with #623564: Create help text for "Vocabs to use" setting this is a UI bug, not a feature request. ;) The field is actually case-sensitive on the vocab tag name, too. ;) I'm a "grey beard" Drupal developer with a ton of experience developing views, and it took me over 10 minutes to get a simple tagcloud block working from when I downloadedthis module (which is very cool, don't get me wrong). This could be dramatically easier to use with a bit of lovin'. ;) Seems like we need a multi-select here, since you could want multiple vocabs in the cloud. If I'm inspired, I might roll a patch for this, but I'm not yet assigning myself -- I've got 100 other things to do on this site I'm building right now...

indytechcook’s picture

Status: Active » Needs review
StatusFileSize
new3.36 KB

Here is a patch to make the vocab a multi select. My initial testing is good. I'd love for another to test before I commit.

yan’s picture

Status: Needs review » Needs work

The patch failed both against 6.x-1.1 and 6.x-dev for me:

$ patch < tagadelic_views-433910-3.patch 
patching file views_plugin_style_tagadelic.inc
Hunk #1 FAILED at 5.
Hunk #2 FAILED at 14.
Hunk #3 FAILED at 26.
3 out of 3 hunks FAILED -- saving rejects to file views_plugin_style_tagadelic.inc.rej
patching file theme.inc
Hunk #1 FAILED at 30.
Hunk #2 FAILED at 47.
Hunk #3 FAILED at 63.
3 out of 3 hunks FAILED -- saving rejects to file theme.inc.rej

I then applied the changes manually which led to a white screen after flushing the caches.

indytechcook’s picture

Thanks Yan, what is in your error log? I'm betting the issue is with the existing view since the options array has changed format. I tried to account for that.

Can you go to admin/build/views and reset the vocab setting for the styles options? http://skitch.com/indytechcook/dkxku/edit-view-neil-d6.local

I'll work on a update function.

yan’s picture

StatusFileSize
new1.42 KB
new1.43 KB

My error log didn't contain anything, I just got a blank screem.

Ok, I deleted my view that was using the module and applied the patch again (manually). Now the selector works -- sweet! For some reason I couldn't apply the patch. So I re-created it. Find it attached split up into two files since I don't know how to get two in one file.

What's missing is the update function.

yan’s picture

No reviews?

gori4ka’s picture

Patch worked for me, thanks! (6.x-1.2)

I can now select from a dropdown...
... but get other error messages, the most meaningful: "Could not find!" :(

Can anyone submit some experience with the module? How does it behave with non-english languages?

Greetings, E.

mstrelan’s picture

An alternative approach is to ignore this setting and add an argument of taxonomy vocab id. Still doesn't give you a drop down though, but at least you can use and integer ID instead of a string.

mstrelan’s picture

Or better still just add a Filter of taxonomy vocab id and select it from the list there.