Multiple locations on a single gmap
Justin W Freeman - April 15, 2009 - 12:21
| Project: | GMap Module |
| Version: | 6.x-1.x-dev |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | rooby |
| Status: | needs review |
| Issue tags: | location, location multiple locations, multiple locations |
Description
Issue #338740: Display locations as polygons on gmap views originally had changes to allow locations to be displayed as polygons on a gmap view as well as allowing multiple locations to be selected on a single gmap for node locations (instead of having a different map per location).
That issue has now been split into two. That issue takes care of displaying locations as polygons and this one is for allowing multiple locations on a single map.
For this patch to work you also need to apply a patch to the location module, which can be found here - #338745: Multiple locations on a single map.
This patch is for gmap 5.x-1.1-rc1.
In the next few days I will look at porting these patches to drupal 6 as I get time.
| Attachment | Size |
|---|---|
| gmap_multi_loc_single_map_5.x-1.1-rc1.patch | 17.76 KB |
#1
Subscribe. This is a GREAT improvement.
Probably should be "needs work" since patch goes to 6.x first then backported? (Am I splitting hairs?)
#2
No, that's fine.
#3
tagging
#4
How is the 6.x patch looking?
#5
Going to start working on a patch for this for drupal 6 now.
#6
Here it is.
This patch is for 6.x-1.x-dev (2009-Apr-18).
The patch does not apply to 6.x-1.1-rc1 but if someone really needs it to another patch can be done for it. Should be a minor change.
Please test this and let me know if you come across any issues.
*And remember, you need the patch for location here - #338745: Multiple locations on a single map
#7
For what it's worth, ran this on the June 9 1.x-dev (don't know where to find he Apr 18 dev):
$ patch gmap.module gmap_single_map_6x-1x.patch
patching file gmap.module
The next patch would delete the file locpick.js,
which does not exist! Assume -R? [n] y
patching file locpick.js
patching file locpick_multi_map.js
patching file locpick_single_map.js
I guess something changed?
#8
I have run the patch in #6 successfully for the 2009-Jun-09 version of gmap 6.x-1.x-dev (also against HEAD from CVS).
If you put the patch file in the gmap directory and run it with:
patch -p0 < gmap_single_map_6x-1x.patchit should work.
It won't work properly without the -p0
#9
#10
Here is a port of the patch in #6 to drupal 5.
It is a little bit improved from the original drupal 5 patch and goes with the much better drupal 5 patch in #338745: Multiple locations on a single map comment #28.
It is for gmap 5.x-1.x-dev (2009-Apr-18).
#11
Tag is missing a comma.
#12
subscribing
#13
subscribing +1
#14
tagging... actually the tag is used on many location module issues, and this ties into that. :) adding back.
See: http://drupal.org/project/issues/search?text=&projects=&assigned=&submit...
#15
I have installed the two patches, checked the "single map" box, updated all modules, etc, but locations works exactly as before. I suspect the gmap patch, because the locations patch installs smoothly, but I get variations on this error when installing the gmap patch:
patching file gmap.module
patching file js/locpick.js
Reversed (or previously applied) patch detected! Assume -R? [n] n
Apply anyway? [n] y
Hunk #1 FAILED at 1.
File js/locpick.js is not empty after patch, as expected
1 out of 1 hunk FAILED -- saving rejects to file js/locpick.js.rej
patching file js/locpick_multi_map.js
patching file js/locpick_single_map.js
If I respond "y" to Assume -R, I still get an error. If I delete locpick.js before patching, the patch complains that it is trying to delete locpick.js but can't find it. In every variation, I end up with a failed hunk.
Am I doing something wrong?
#16
Clarification: I installed the patch thusly: patch -p0 < gmap_single_map_6x-1x.patch
#17
(reverting category)
#18
@gjmokcb:
I will be having a look at a couple of minor bugs within the next week so I'll check out your error then.
#19
Subscribing
#20
Subscribing
#21
I have done a lot of work on this (I work for Justin) and there is not really any free time for us to be working on this at the moment so I will do it in my own time.
I hope to get to it pretty soon and fix up a few more details.