Changing the Subject Line: and/or Message: in admin/settings/emailpage.

There are no errors reported in the logs when you submit the admin page.

Comments

icenogle’s picture

Piling on: Changing the "Sender Address" doesn't work, either. By "doesn't work," I mean that the change isn't saved when you "Save Configuration."

As the original submitter noted, there are no errors flagged in the watchdog.

budda’s picture

The fix is simple.

The problem is all settings are being stored in ONE Drupal variable as an array. This is because of a mis-configuration in the Forms API.

Check out function emailpage_settings() line 185:-

  $form['emailpage'] = array(
      '#type' => 'fieldset',
      '#title' => t('Emailpage settings'),
      '#tree' => TRUE,
    );

The correct code should be:

  $form['emailpage'] = array(
      '#type' => 'fieldset',
      '#title' => t('Emailpage settings'),
      '#tree' => FALSE,
    );

The '#tree' puts all form values in to an array. You don't want that!

I'd make a patch for the bug, but it's too simple to be worth the hassle!

Patrick Nelson’s picture

budda,

Fair comment!

"Patch" applied and all is well. Thanks for the tip.

budda’s picture

Status: Active » Reviewed & tested by the community

Ok, so it's not a "true" patch, but the fix needs to be added to CVS code anyway.

zoo33’s picture

I included this fix in a large patch here: /node/62209#comment-96634.

darren oh’s picture

Status: Reviewed & tested by the community » Fixed

Fixed in CVS commit 45506.

darren oh’s picture

Status: Fixed » Closed (fixed)