If #428932: Improve mapping UI, support provider and client lands we should be able to remove mapping functionality from openid_client_ax in favor of the mapping in openid_cp_field.

This is a follow up on http://drupal.org/node/428932#comment-1456696 and the Roadmap post on groups.drupal.org.

Comments

aron novak’s picture

StatusFileSize
new20.92 KB

Here is a patch, but it needs testing.
Be aware that this patch only makes sense with http://drupal.org/node/428932 (patch for openid_cp_field)
This removes the unneeded mapping code and calls openid_cp_field where we need mapping data.
Maybe the attributes should live in an .inc file.

aron novak’s picture

Status: Active » Needs work
StatusFileSize
new23.62 KB

This is in "needs work" status because of the following:
- at this point we cannot declare if an attribute is required or optional. It needs to be discussed. Do you see such a use-case when you would like to refuse the openid registration because of a missing attribute?

Download openid_cp_field as well and apply #428932: Improve mapping UI, support provider and client .
Study openid roadmap as well on g.d.o. (http://groups.drupal.org/node/21221)

darren.ferguson’s picture

Aron can you redo this patch for the latest branch of the client ax module under DRUPAL-6--1 in cvs please i get failures when trying too apply this see below

patching file openid_client_ax.module
Hunk #1 FAILED at 5.
Hunk #2 FAILED at 40.
Hunk #3 FAILED at 58.
Hunk #4 FAILED at 144.
Hunk #5 FAILED at 169.
Hunk #6 FAILED at 177.
6 out of 6 hunks FAILED -- saving rejects to file openid_client_ax.module.rej

aron novak’s picture

StatusFileSize
new27.63 KB

Here is the rerolled patch.
I see some serious problems here:
- openid_cp_field does not support the mapping of the field of user object. This feature is removed by this patch
- no support for multiple values at the moment
- at #428932: Improve mapping UI, support provider and client I did a mistake, it does not send back the fields according to the openid specs, it needs to be fixed before try out to use the two modules together

I added dependency for openid_cp_field, are we happy with this?

aron novak’s picture

StatusFileSize
new27.74 KB

Here is a new patch.
It tested and works with openid_cp_field plus #428932: Improve mapping UI, support provider and client

However we still need to discuss the issues in #4

darren.ferguson’s picture

Aron, patch is now applied too the cvs trunk.

Right now if we want to do the attribute exchange or simple registration i think the cp field dependency should be there since that is now going to be the main linking module. If anyone has any objections raise them, but i think that is a solid approach since that module is going to take over the mapping portions for us on both ends.

aron novak’s picture

Status: Fixed » Needs work
StatusFileSize
new2.04 KB

Here is a new version of #4 where the SReg is respected, see #430332: Make SREG independent of Persona, the decoupling of openid_provider_sreg and openid_provider_persona is just coming.
[edit: it was a mistake, posted here accidentally. that patch is for openid_cp_field, ignore it]

darren.ferguson’s picture

Aron the patch for #7 above seems already to be in the cvs for the module.

aron novak’s picture

Status: Needs work » Fixed

Thank you for the fast commits! I'm really glad that it proceedes so fast :)
I did some mistakes again :(, i open separate tickets for them.

darren.ferguson’s picture

Aron, not a problem, sounds good will definitely have the commits in the system within 12 hours that way the latest code is there.

Status: Needs work » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.