Remove @ from selectors

jcmarco - April 15, 2009 - 18:50
Project:Paging
Version:6.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed
Description

Related with issue #358082: jQuery 1.3 in Drupal 6.x

To help signup work with jQuery 1.3.2 in jQuery Update can we please remove the @ in the selectors. It was depreciated as of 1.2 and removed in 1.3. Change highlighted below.

jQuery 1.2.x:
$("a[@href*='admin/build/testing']").doSomething();

jQuery 1.2.6 and 1.3.x:
$("a[href*='admin/build/testing']").doSomething();

More detail at http://docs.jquery.com/Selectors/attributeHas#attribute

#1

jcmarco - April 17, 2009 - 08:42
Status:active» needs review

I have been testing this module with new jquery and I found issues in the node screen and in the admin screen.
I attached patches that fix this deprecated selectors, and everything work fine again.
It doesn't affect to standard jQuery Drupal version.

AttachmentSize
paging_js.patch 446 bytes
paging_admin_js.patch 2.31 KB

#2

Gurpartap Singh - April 19, 2009 - 11:32
Status:needs review» fixed

http://drupal.org/cvs?commit=198790

Thanks!

#3

System Message - May 3, 2009 - 11:40
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.