Also includes my previous patch.

CommentFileSizeAuthor
#2 validateage_post_391884.diff1.13 KBxibun
validateage.diff4.09 KBxibun

Comments

gwen’s picture

gwen commented

I don't have time right now to test the patch, but if some folks in the community feel like doing so, please update this issue once it's been done so I can know whether I should apply the patch or not. Otherwise, I'll test when I have a little more time.

xibun’s picture

xibun commented
StatusFileSize
new validateage_post_391884.diff1.13 KB

Patch rerolled assuming http://drupal.org/node/391884#comment-2186400 is applied.

xibun’s picture

xibun commented

@gwen: the only argument I can find against this patch is: "the 1 year threshold shouldn't be hardcoded" - this can potentially be a conflict when you set your legal age to 0.5 years... but this problem is just hypothetical, if you don't need a resonable legal age limit, then you actually won't install this module...

what can I do to get both of my patches committed?

gwen’s picture

gwen commented
Status: Needs review » Fixed

Changes have been incorporated and will be in the mod once the packaging script does its thing.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.