The menu item titles should not be passed through the t() function as the menu handler is expecting untranslated menu items (see hook_menu()). This will lead to translated strings being passed through the translation system again, causing errors.

CommentFileSizeAuthor
#4 scheduler_remove_menu_t_unified.patch1.78 KBeric-alexander schaefer
#2 scheduler_remove_menu_t.patch884 bytesyarimbiyik

Comments

eric-alexander schaefer’s picture

eric-alexander schaefer commented

Thanks for reporting. I gues we should also look at version 5.x...

yarimbiyik’s picture

yarimbiyik commented
StatusFileSize
new scheduler_remove_menu_t.patch884 bytes

Here's a patch for the issue..

geodaniel’s picture

geodaniel commented
Status: Active » Needs review

Thanks for the patch Emre. Patches are usually better provided as a universal diff (diff -up), but this should work fine as it's only a simple patch. There are some tips on the creating patches page.

Eric, this only applies to the Drupal 6 version, as the Drupal 5 version of hook_menu is expecting the translated item.

eric-alexander schaefer’s picture

eric-alexander schaefer commented
StatusFileSize
new scheduler_remove_menu_t_unified.patch1.78 KB

Commit: http://drupal.org/cvs?commit=198584

I attach a universal diff for those who care.

Thanks guys,
Eric

eric-alexander schaefer’s picture

eric-alexander schaefer commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.