Optimize JavaScript files = breaks POPUPS module
vertazzar - April 16, 2009 - 22:57
| Project: | Popups API (Ajax Dialogs) |
| Version: | 6.x-2.0-alpha5 |
| Component: | User interface |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | needs review |
Description
if you enable the
Optimize CSS files, Optimize and Minify JavaScript files the popup module will stop working as intend
Is there any way that you can fix this, cause if you keep these settings off, the site will be pretty slow :|
the reason im using alpha 5 is that it works very well - the hooks defined work perfectly...
#1
I have found this problem but only with optimise js. The error is that Drupal.theme() is missing.
#2
Thanks for reply, is there any chance that will be fixed? Cause its pretty annoying when you cant optimize your site.
#3
Subscribing.
#4
Subscribing.
#5
any chance that this is fixed?
#6
mah this totally sucks and just cost me like five hours to debug :>
i'd really appreciate this getting fixed sometime soon because performance is always critical :/
#7
I confirm this...
#8
There are some semi-columns missing at the end of some function, but fixing this does not fix the issue. Maybe it's because of the use of eval() : http://drupal.org/node/172169
A temporary fix could be to exclude all the Popups .js files from the agregation everytime drupal_add_js() is called.
#9
Here's a patch that got this working for us.
#10
Just to let you know, Popups is dead in D7, long live jQuery UI and drupal_add_dialog()
#11
Well thats fine, but D6 is the beast today, and I think we all appreciate starbow's work here ; )
I believe that after implementing the patch, and enabling "Optimize Javascript Files", the functionality of AJAX reloading the page from giving a link the class "popups-form" does not work properly. I'm using alpha5.
The popup box loads the new data after Submit, but not the parent page.
Without "optimize js" the parent page reloads properly.
Can anyone verify or deny this?
#12
I tried the patch in #9 and works for normal popups, but breaks for form upon submit, like the avatar upload...Got the bad response form and the picture did not get uploaded...
#13
I use 6.1 stable version, and I'm not intending to use 6.2 because its bugged as hell.