I tested this page with multiple girls and they all clicked the "I already have an account, I'd like to use Facebook connect features." instead of "Don't have an account? Create an account now"

The prompt before this logs them into facebook session, so the person is thinking "wait.. I already have a facebook account" NOT "No I don't have an account with this drupal site"

To help prevent this future confusion I changed the code to:

function fbconnect_prompt_page() {
drupal_set_title('Facebook Connect');
$reg_msg = t("Click here to create a new account with ".$_SERVER['SERVER_NAME']);
$link_msg = t("Click here to connect your existing account with Facebook");
...
?>

If you have any improvements on this (say using whatever the registered drupal var is instead of $_SERVER[] let me know...

Comments

falieson’s picture

falieson commented

um..
I changed it to:

function fbconnect_prompt_page() {
  drupal_set_title('Facebook Connect');
  $reg_msg  = t("Click here to create a new account with ".$_SERVER['SERVER_NAME']);
  $link_msg = t("Click here to connect your existing account with Facebook");
...
elliotttf’s picture

elliotttf commented

Thanks for the snippet, it might be better to display the site name though if available, like this:

$reg_msg  = t("Don't have a account on @site_name? Create an account now.", array('@site_name' => variable_get('site_name', 'Drupal')));

And you could change the default to $_SERVER['SERVER_NAME'] instead of Drupal just in case the site admin never set their site name (can't remember if install makes you do that or not).

falieson’s picture

falieson commented

I'm not sure either. I didn't know what the drupal premade variables were so I'll change it to that in my local. I hope this change, or something similar gets made for the next release or snapshot, because I know this issue effected every single girl that tried to fbconnect on my site.

LaNets’s picture

LaNets commented
Assigned: Unassigned » LaNets
Status: Patch (to be ported) » Fixed
LaNets’s picture

LaNets commented
Status: Fixed » Closed (fixed)