mcrypt missing... test at install time
AlexisWilke - April 17, 2009 - 06:21
| Project: | AES encryption |
| Version: | 6.x-1.3 |
| Component: | Code |
| Category: | bug report |
| Priority: | minor |
| Assigned: | Unassigned |
| Status: | closed |
| Issue tags: | installation requirement |
Jump to:
Description
Hi there,
I know it is clearly written on your home page that the mcrypt module needs to be installed before this thing works.
Now, although I agree with that, wouldn't it be cleaner to forfeit installation if such a dependency is missing rather than installing the module anyway and then generate an error which has the side effect of creating a new white screen of death? 8-)
I'm attaching a small addition to your .install file, so really not adding anything to the module itself, that will make sure the PHP module is available and fail the installation if not, in a clean way.
Thank you.
Alexis Wilke
P.S. if you want your $Id $ to start working, by the way, add a colon as in: $Id: $
| Attachment | Size |
|---|---|
| aes-6.x-1.3-requirements.patch | 584 bytes |
#1
Hey
I didn't realize you would get a white screen of death if you don't have the mcrypt extension. I vaguely recall testing that and just getting a warning when trying to enable it, but that was a long time ago, and maybe the behaviour varies depending on how PHP is configured. That was probably in Drupal 5 as well so maybe Drupal 6 handles things differently.
Anyway, you're right, that's a better way of doing it. I'll probably make a new release soon anyway since there are 1 or 2 minor things I would like to fix in the current one, so I'll include your patch there then.
Thanks for contributing!
#2
Another note, if you are to have some time for some cleanup... you are supposed to only used spaces, no tabs. My tabs are set to 8 chars, quite obvious that you have some here and there. 8-)
And yes, it could have changed between D5 & D6. And it is, I'm sure, something I won't test again since my server now has the mcrypt module 9-)
#3
Ah yes I know, I prefer tabs myself so that's what I use when I develop, but I normally convert to spaces before I commit. I guess I just forgot to do it that time.
#4
Fixed in 1.4, thanks!
#5
Automatically closed -- issue fixed for 2 weeks with no activity.