PostgreSQL does not want 'from' and 'to' as fields
AlexisWilke - April 17, 2009 - 06:56
| Project: | Webmail Plus |
| Version: | 6.x-1.14 |
| Component: | Code |
| Category: | bug report |
| Priority: | critical |
| Assigned: | AlexisWilke |
| Status: | active |
| Issue tags: | field, PostgreSQL |
Description
I'm not too sure why it did not jump at your eyes, but a field named 'from' and one named 'to'?! These are SQL keywords! 8-)
Well... PostgreSQL refuses them. So we need to rename them. It is easy to change the install file, but you use that field all over the place. (The word 'from' is found on 143 lines of code in your webmail_plus directory... that does not include any sub-folder!)
So, I do not mind to give you a patch with the fix, but I'd like to know what you'd like to name these fields.
I propose: from_email or email_from.
Of course, the cc field should also be renamed to be more... symmetrical, or something like that (it's late already!).
email_from
email_to
email_cc
How does that look?
Thank you.
Alexis Wilke
#1
Please hold off on the patch since I am about to release a new version. Wouldn't want to do the same work twice.
#2
Do you have an ETA? When is "about to"? 8-)
Thank you scripthead!
#3
I just pushed the new release 6.x-1.16 - if possible please address the issues you described and provide a patch.
#4
Hi Scripthead,
There is a patch between what I had more or less working (although I've never seen any emails) and your 1.16 version.
I decided to switch to my own mail system because yours includes a download from the mail server each time I click on a link. When you have over 1,000 email in your POP3 account, that's obviously unbearable. And even if I had just a few emails, it would waste a lot of time loading the headers each time, for nothing! At least you should have a timer to make sure that this process occurs only once every now and then (10 to 15 minutes is commonly used.)
Another problem is that I was looking for a solution that would give me a way to offer my users to setup their own email system. In your case the Drupal setup is done in the admin area!
Well... anyway... Hope the patch helps someone.
Thank you.
Alexis Wilke
#5
Thanks for the patch, I will review it ASAP.
FYI Webmail does not pull all emails down every time you click a link. With IMAP it uses an overview command and only pulls new emails in.
#6
I guess that when the emails don't make it across, for some reason, it feels like this is broken. 8-)
I've seen that someone else had a similar problem (i.e. no emails to be looked at.)
Thank you.
Alexis