Project:Community Tags
Version:6.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

Related with issue #358082: jQuery 1.3 in Drupal 6.x

To help Community Tags work with jQuery 1.3.2 in jQuery Update can we please remove the @ in the selectors. It was depreciated as of 1.2 and removed in 1.3. Change highlighted below.

jQuery 1.2.x:
$("a[@href*='admin/build/testing']").doSomething();

jQuery 1.2.6 and 1.3.x:
$("a[href*='admin/build/testing']").doSomething();

More detail at http://docs.jquery.com/Selectors/attributeHas#attribute

AttachmentSize
community_tags_js.patch533 bytes

Comments

#1

Status:needs review» reviewed & tested by the community

reviewed - ok and needed if you use jQuery Update

By the way:
the "@" syntax is already deprecated in jQuery 1.2.x

#2

thanks for catching this, I will commit tomorrow.

#3

Status:reviewed & tested by the community» fixed

committed

#4

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

#5

Status:closed (fixed)» active

this patch should also be applied for community tags version 6.x-1.0-beta2

best,
walter

#6

Status:active» fixed

I will create a new release soon, but regardless this is committed to the 6.x branch, and should be considered fixed.

#7

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.