In the admin/contentmanagement/content, in the first fieldset "Show only items where" there is a bullet point that shouldn't be displayed. Please have a look at the screenshot attached.

Win: Firefox 3.0, IE 6&7;

CommentFileSizeAuthor
#5 bullet_point.patch975 bytesARep
#3 bullet_point.patch974 bytesARep
#1 bullet_point.patch507 bytesARep
bulletlist.jpg43.89 KBARep

Comments

ARep’s picture

ARep commented
Status: Active » Needs review
StatusFileSize
new bullet_point.patch507 bytes

Added "list-style-image: none;" to

#node-admin-filter ul {
list-style-type: none;
--> list-style-image: none;
padding: 0;
margin: 0;
width: 100%;
}

in node.css. This should fix the issue.

Angelo.

swentel’s picture

swentel commented
Status: Needs review » Needs work

While you're at it, this bullet is also on admin/user/user, let's fix that in the same run :)

ARep’s picture

ARep commented
Status: Needs work » Needs review
StatusFileSize
new bullet_point.patch974 bytes

Added a fix for admin/user/user.

#user-admin-filter ul {
list-style-type: none;
--> list-style-image: none;
padding: 0;
margin: 0;
width: 100%;
}

Please note:
instead of targeting every single ul element in the different sections (#user-admin-filter ul, #node-admin-filter ul) a better solution could be to target all the ul elements in the fieldset with the id=edit-filters, so that with one css declaration we could include them all.

Something like:

fieldset#edit-filters ul {
list-style-image:none;
list-style-type:none;
margin:0;
padding:0;
width:100%;
}

Angelo.

mcrittenden’s picture

mcrittenden commented

If those two places are the only places the bullet points show up, I'd vote for doing it as you've done it. No point making an overarching declaration to fix two places, especially when it's just a two line fix as it is.

Make sure to use two spaces instead of a tab when indenting. Your addition under #user-admin-filter ul seems to be a tab. More at http://drupal.org/coding-standards (apologies if you already know and love this link...not trying to insult you).

Necessary patch, good catch, I'd say just fix the tab and we're ready to roll.

ARep’s picture

ARep commented
StatusFileSize
new bullet_point.patch975 bytes

Updated patch to remove tabs. Please review.

Thanks mcrittenden for your suggestion and advice;

I have no idea if there are other places where that issue shows up, and I agree with you about the fact that if those are the only 2 cases there is no point to add a "general css rule".

mcrittenden’s picture

mcrittenden commented

Patch applies cleanly and works fine. Abides by coding standards. Let's do it :)

moshe weitzman’s picture

moshe weitzman commented

Why is that bullet in the HTML to begin with? Just want to make sure we are not covering up something deeper.

mcrittenden’s picture

mcrittenden commented

moshe: Because the form is laid out as an unordered list...is that what you're asking?

ARep’s picture

ARep commented

Moshe, as mcrittenden already replied, the form is wrapped in a unordered list that inherits the following css propery:

ul, li.leaf {style.css?G (line 93)
list-style-image:url(images/menu-leaf.gif);
}

In order to hide any bullet point for the specific form the following css has been set (this is the actual css code)

#node-admin-filter ul {node.css?G (line 9)
list-style-type:none;
margin:0;
padding:0;
width:100%;
}

The problem is that if list-style-image is NOT set to none, even if we set list-style-type:none, the image will be still displayed; that's why the bullet point (menu-leaf.gif) is showing.

We need to add list-style-image:none for the 2 specific cases (#node-admin-filter ul, #user-admin-filter ul) in order to hide the bullet image.
We colud also rewrite the html so that the form is not wrapped in a unordered list, but I believe this solution is too complicated at this stage.

Hope this help.

moshe weitzman’s picture

moshe weitzman commented
Status: Needs review » Reviewed & tested by the community

Thanks for the explanation.

ultimateboy’s picture

ultimateboy commented
Status: Reviewed & tested by the community » Postponed

I dont know if this is the right move. The content filters are far from semantic in their current state. Seriously, a definition list inside of an unordered list? Anyways, I think that this 'problem' should be fixed by fixing the real issue, which is the fact that it is not semantic, and that issue is #365299: Make content filters semantic (ul instead of dl), so I am going to mark this as postponed until that issue gets some attention.

wretched sinner - saved by grace’s picture

wretched sinner - saved by grace commented
Status: Postponed » Reviewed & tested by the community

Based on Moshe being happy with this, I say fix it now, and then work on improving the semantics.

mcrittenden’s picture

mcrittenden commented

I agree with wretched sinner. There's no harm in fixing this in the meantime. There's always a chance the semantics issue gets marked "won't fix" anyway.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Reviewed & tested by the community » Needs work

Just replacing

   list-style-type: none;

with

   list-style: none;

Should be sufficient here.

Also, this patch needs to be tested on different browsers. IE being the special case here.

ARep’s picture

ARep commented

Hi Sun,
you are right; I didn't use list-style:none; just because of IE. I am not sure how to handle the css for IE. Do I have to create an ie.css file? Is there already a css file for IE?

Thanks.

sivaji_ganesh_jojodae’s picture

sivaji_ganesh_jojodae commented

The patch in #5 seems to be working fine in FF3.

@ultimateboy
Your patch remove the bullet only in content filter, leave user filter bullet as such.

sivaji_ganesh_jojodae’s picture

sivaji_ganesh_jojodae commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch failed testing.

casey’s picture

casey commented
Status: Needs work » Fixed

Issue doesn't exist any more.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Fixed » Closed (duplicate)

In addition, the entire markup for those filter forms is fixed properly in #732914: Improve the markup/CSS for content and user filter forms

Therefore marking as duplicate