The problem is, when I select to have a node by default private it's not going to make the node by default private. Here is way:

Line 13 has a typo:
- define('PRIVSTE_AUTOMATIC', 2);
+define('PRIVATE_AUTOMATIC', 2);

There seems to be some confusion on lines 137 and following. Here is what my if statement looks like -> and that's how it works:

if (empty($node->nid)) {
		if(PRIVATE_AUTOMATIC){
		  $privacy = TRUE;
		}
      }
      else {
        $privacy = $node->private;
      }

Would be cool if you could take theses fixes into the next release.

CommentFileSizeAuthor
#5 private.txt9.16 KBashiwebi
#3 436620_private_typos_3.patch3.02 KBgreggles
#2 436620_private_typos.patch3.04 KBgreggles

Comments

ashiwebi’s picture

ashiwebi commented

Please send me the detail If you know

'Private' check box only shows on certain node types?

This patch is available for drupal5.Any one working on drupal 6 patch but as they mentioned that they fix this issue in drupal 6 .

But If you checked this Disabled (always public) option.It should remove the checkbox option from the Node type or content type.

Please provide the readme.txt file for this module.

There is no readme file in this.

Help needed immediately

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Title: Enabled (private by default) -> doesn't work » Typos, variable names, and whitespace cleanup
StatusFileSize
new 436620_private_typos.patch3.04 KB

There was no patch here, and I think the logic for the second piece was wrong. It would ignore the value set by the admin as the default.

Attached patch fixes the

1. The variable name is in the format private_ $node->type
2. Logic flaw in the default setting
3. Trailing whitespace

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
StatusFileSize
new 436620_private_typos_3.patch3.02 KB

...and now with 100% less debug code.

ashiwebi’s picture

ashiwebi commented

Thanks your code implement perfectly with disabled option for the Node type.

Have you tested the code completely.

ashiwebi’s picture

ashiwebi commented
StatusFileSize
new private.txt9.16 KB

Please find the attached file of corrected private.module.

Let me know whether the file I am putting here needs any further changes.

Thanks every one who help me in this private module

ashiwebi’s picture

ashiwebi commented

Please give me your feedback on the private module whether my above attached file is ok or any further changes I have to implement.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

@ashiwebi - I don't look at full files that have been uploaded. The are hard to review or compare to other proposed changes - that's why we use http://drupal.org/patch/ patch files.

Also, your attitude of demanding action by other people is somewhat inappropriate.

ashiwebi’s picture

ashiwebi commented

Sorry

If you get hurted by this.I never worked on the patches before.

Thanks for your kindness.

eaton’s picture

eaton commented
Status: Needs review » Fixed

Committed. Will be part of the next release. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.