When making theme and module disabled in nagios module admin, the need to update my themes and modules are reported to Nagios...
Thanks !
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | nagios-436650-HEAD.patch | 2.65 KB | helmo |
| #4 | nagios-436650-d6.patch | 2.7 KB | helmo |
| #1 | drupal_nagios_settings_description.patch | 2.3 KB | helmo |
Comments
Comment #1
helmo commentedThe checkboxes for themes and modules only function to gather performance data.
The "WARNING=Module and theme update status" is generated by the 'requirements' checkbox which calls the requirements checking code from Drupal core.
I agree that the settings page is not clear about this.
The attached patch tries to clarify this.
Comment #2
kbahey commentedYour patch is unrelated to this issue's title.
I see that it is a good idea.
However some comments:
1. We do not do a t() on a variable. The t() should be in the array definition itself. So move it there.
2. You need to prepare a similar patch for the performance module as well.
3. We need D6 and D7 versions of this patch.
Comment #3
helmo commentedComment #4
helmo commented> However some comments:
>
> 1. We do not do a t() on a variable. The t() should be in the array definition itself. So move it there.
done
> 2. You need to prepare a similar patch for the performance module as well.
I'm not entirely sure what you mean here. As far as I can see the performance module does not provide a hook_nagios_settings() implementations.
> 3. We need D6 and D7 versions of this patch.
done
Comment #5
kbahey commentedThank you.
I committed your change to both 6.x and HEAD.