Uninstall hook calls loginticket hook unnecessarily

crdant - April 17, 2009 - 14:09
Project:Login Ticket API
Version:5.x-1.x-dev
Component:Code
Category:bug report
Priority:minor
Assigned:crdant
Status:closed
Description

I added this as a comment on the "Drupal 6 port" issue because I was looking at it in the context of using the module under Drupal 6, but it applies equally well for Drupal 5. The uninstall hook invokes loginticket_delete in order to make sure that hook_loginticket is invoked before dropping the table {loginticket}. This code seems unneeded since the modules implementing hook_loginticket will declare a dependency on loginticket and thus will be disabled by the time loginticket can be uninstalled.

I've implemented a patch that takes out the logic around calling loginticket_delete.

AttachmentSize
loginticket_uninstall.patch272 bytes

#1

crdant - April 29, 2009 - 21:37
Assigned to:Anonymous» crdant
Status:needs review» closed
 
 

Drupal is a registered trademark of Dries Buytaert.