and admin menu
Moonshine - April 17, 2009 - 20:32
| Project: | Invisimail |
| Version: | 6.x-1.x-dev |
| Component: | Code |
| Category: | feature request |
| Priority: | minor |
| Assigned: | Unassigned |
| Status: | closed |
Description
Just a quick note..
Was having trouble with Invisimail hitting due to the Typogrify filter inserting before some addresses for orphan control. Even after some re-arrangement I wasn't very happy with some of the other results caused so I'm thinking this may be a good addition for Invisimail. I don't think it would hurt anything to go from:
<?php
$pattern = '!(<p>|<li>|<br />|[\s\(])([A-Za-z0-9._-]+@[A-Za-z0-9._-]+\.[A-Za-z]{2,4})([.,]?)(?=(</p>|</li>|<br />|[\s/)]))!i';
?>to
<?php
$pattern = '!(<p>|<li>|<br />|[\s\(]| \;)([A-Za-z0-9._-]+@[A-Za-z0-9._-]+\.[A-Za-z]{2,4})([.,]?)(?=(</p>|</li>|<br />|[\s/)]))!i';
?>One other thing is that I noticed Invisimail has a setting form in Site Configuration in addition to individual ones for configuration within each formatter. Is the one in Site Configuration actually used for anything?
Thanks!
#1
Can you roll a patch for that change so that we can test it and see if it breaks anything else? (I don't actually understand the regexes in this module; I inherited it. :-) )
#2
Here's a patch for this.
I don't see a link in site configuration, only in Input Formats so I'm not sure if you're talking about a different version.
#3
The regex was just completely rewritten to be somewhat saner to comprehend. It probably fixed this, too. :-) If not, please reopen with a new patch. Thanks.
#4
Automatically closed -- issue fixed for 2 weeks with no activity.