Closed (fixed)
Project:
Ubercart
Version:
6.x-2.0-rc1
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
17 Apr 2009 at 20:39 UTC
Updated:
11 May 2009 at 18:40 UTC
Jump to comment: Most recent file
I believe this affects all versions (uc1 and uc2).
At least in uc_ups_fulfill_order_validate function and based on my results with UPS shipping tools,$error->errorseverity[0]->data() is set to 'Hard' when an error is present and not 'HardError' as the current code checks against.
In other words, I believe the statement:
if ($error->errorseverity[0]->data() == 'HardError') {
should be:
if ($error->errorseverity[0]->data() == 'Hard') {
This may also affect uc_ups_quote function, but I have not tested it.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | ups_error_severity.patch | 1.54 KB | Island Usurper |
| #2 | ups_error_severity.patch | 1.3 KB | Island Usurper |
Comments
Comment #1
rszrama commentedComment #2
Island Usurper commentedI feel like this has gone back and forth several times. And rather than figure out if the two services have different specifications, or the documentation is wrong, I'm just going to change the code to handle both situations. If it works, I'll backport it to Ubercart 1.x as well.
Comment #3
Island Usurper commentedThe validate function wasn't doing what I intended anyway, which is to set a form error and return to the shipment form. New patch fixes that (as tested on the Livetest) and is committed.