Currently, you have to place the TCPDF or dompdf in the root directory of the module in order for PDF generation to work. This makes updating to newer releases of the module cumbersome, as it is difficult to differentiate which files are from the module, and which are from the PDF generator. As it stands, I simply re-download TCPDF from sourceforge and add it to the new module each time there is an update. This is less than ideal.

If the module were to look in a subdirectory, then it would make upgrading to newer module releases much simpler.

Comments

jcnventura’s picture

jcnventura
Primary language English
commented
Status: Active » Postponed (maintainer needs more info)

I am pretty sure that it looks in a subdirectory (as long as it is a subdirectory of the module).

Ideally, TCPDF would be installed outside of the module directory, but that requires #397154: Add support for user-selectable external library path. And I don't think that will be accepted before Drupal 8.

João

rsvelko’s picture

rsvelko commented

agree with #1 that this is a thing that this module does already - no problem to just move the files in a subfolder - they will be detected. Use diff -r with a clean print module folder to determine which are the files...

To prove my point:

listing of print dir:

-rw-r--r-- 1 vla vla 31768 Feb 10 23:42 CHANGELOG.txt
-rw-r--r-- 1 vla vla 379 Nov 16 2007 CREDITS.txt
-rw-r--r-- 1 vla vla 2999 Feb 20 00:39 INSTALL.txt
-rw-r--r-- 1 vla vla 14940 Apr 23 2006 LICENSE.txt
-rw-r--r-- 1 vla vla 70 Aug 24 2007 MAINTAINERS.txt
-rw-r--r-- 1 vla vla 4180 Feb 20 00:39 README.txt
drwxr-xr-x 2 vla vla 4096 Apr 15 22:06 api
drwxr-xr-x 2 vla vla 4096 Apr 15 22:06 css
drwxr-xr-x 5 vla vla 4096 Apr 17 18:01 dompdf-0.5.1
-rw-r--r-- 1 vla vla 344640 Apr 17 18:01 dompdf-0.5.1.tar.gz
drwxr-xr-x 2 vla vla 4096 Apr 15 22:06 icons
-rw-r--r-- 1 vla vla 17524 Mar 27 02:12 print.admin.inc
-rw-r--r-- 1 vla vla 391 Apr 15 22:06 print.info
-rw-r--r-- 1 vla vla 8362 Mar 17 21:55 print.install
-rw-r--r-- 1 vla vla 24832 Apr 15 21:44 print.module
-rw-r--r-- 1 vla vla 24402 Apr 15 21:52 print.pages.inc
-rw-r--r-- 1 vla vla 1729 Mar 24 01:04 print.tpl.php
drwxr-xr-x 2 vla vla 4096 Apr 15 22:06 print_mail
drwxr-xr-x 2 vla vla 4096 Apr 15 22:06 print_pdf
drwxr-xr-x 8 vla vla 4096 Apr 17 18:01 tcpdf
-rw-r--r-- 1 vla vla 10973171 Apr 17 18:01 tcpdf_4_5_019.zip
drwxr-xr-x 2 vla vla 4096 Apr 15 22:06 tests
drwxr-xr-x 2 vla vla 4096 Apr 15 22:06 translations

rsvelko’s picture

rsvelko commented
Status: Postponed (maintainer needs more info) » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.