admin/settings/flickr: Username not replaced with User Id

aaronbauman - April 17, 2009 - 21:10
Project:Flickr
Version:6.x-1.x-dev
Component:flickr (main module)
Category:bug report
Priority:normal
Assigned:aaronbauman
Status:closed
Description

at least in my instance, the function flickr_admin_settings_submit never fires, and if the user enters a Username instead of the esoteric User Id, the validation passes but all other functionality doesn't work since flickr_default_userid doesn't store the proper uid.

This patch adds a single line to the FAPI form function to make sure that the FAPI submit function fires.

AttachmentSize
flickr.admin_.inc_.patch344 bytes

#1

soxofaan - April 19, 2009 - 10:08

I could reproduce the issue and the patch indeed solves it.

One minor remaining issue is that system_settings_form_submit() is called twice on submit,
I attached an updated patch to solve that too.

AttachmentSize
437116_flickrusernamereplacement.patch 923 bytes

#2

nosro - May 28, 2009 - 15:50

I ran into this and my solution was to enter the esoteric User Id manually into the Flickr settings form, rather than the username. It validates and gets stored and used by Flickr attach with no problems. (not a user friendly approach, but a non-patch solution for the moment)

Edit: This is, indeed, a workaround :)

#3

soxofaan - May 27, 2009 - 16:51

my solution was to enter the esoteric User Id manually

that's not a "solution", but a "workaround" ;-)

#4

ksenzee - June 24, 2009 - 19:34
Status:needs review» fixed

Good catch. Thanks. Committed to DRUPAL-6--1.

#5

System Message - July 8, 2009 - 19:40
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.