Hi,

I would like to hear your opinion on this matter, let me explain better.

Right now, when language negotiation in enabled, the links of the feed items are prefixed with the current language, which for drupal means the current interface language. Since feeds don't have any User Interface, I think that links in feeds should really use the actual content language.

To achieve that I made the changes in the attached patch, what do you think about this?
I am still making up my mind, but I am almost convinced that my observation makes a lot of sense.

I will propose the same discussion to the core node module and will link the thread here.

Thanks,
Antonio

CommentFileSizeAuthor
views_feeds_displays_use_content_language_prefix_v0.patch1.1 KBao2

Comments

ao2’s picture

ao2 commented

We could discuss about this issue also in #437434: Content language prefix for feed items links since it applies to the core node module as well.

Regards,
Antonio

dawehner’s picture

dawehner
Primary language German
commented
Status: Active » Needs work

The code makes sense for me, but i don't like

+    $__langs = language_list();

$__langs is not the way how drupal uses variables. $langs or $languages will be enough

ao2’s picture

ao2 commented

@dereine: thank for commenting on this one.

Actually when I wrote this post I didn't have a clear picture of the Interface Language and Content Language dichotomy. And also, the fact that a feed doesn't have a UI, doesn't mean that the link won't be visited using a browser.

Drupal looks to interpret language prefix mainly as the Interface Language so, by using links with Content Language prefixes here we will just point to a page where the Interface Language is equal to the Content Language, no real gain.

Ideally there should be no language prefix at all in links from feeds letting the browser negotiate the Interface Language and Drupal doing the redirect to the URL with the right language prefix, too complex?

About the code, I think that I used that writing for the var name just to remember to look if Drupal has some guideline about temp variables used only once.

Regards,
Antonio

esmerel’s picture

esmerel commented
Status: Needs work » Closed (won't fix)

No activity for more than 6 months