There are two strings to be changed:
In Message can't be sent to @name because he has been blocked the 'he' must be changed by 'it'.
In More actions.. there should be another . at the end.
For translation purposes: could you tell me what '!undo' can be in The previous action can be !undo.. For translation purposes it is mostly better to have separate strings but not variables.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | 437524.string_fixes2.patch | 2.49 KB | berdir |
| #2 | 437524.string_fixes.patch | 1.56 KB | berdir |
Comments
Comment #1
naheemsays commentedAnother string that can potentially be improved from the email notifications module:
EDIT - as a reply to the last post, currently !undo is a place holder for the word undone. Not the best IMO and I would prefer if the text was somehow changed to reflect what actually happens. "You have marked the conversations as read. Mark as unread" would IMO be better but it may take adding more logic.
Comment #2
berdir!undo is work in progress, I'm not happy about it either :) The idea is to make it configurable somehow.
Attached is a patch to fix the two mentioned strings. Note that the first is is only an example and is not actually used.
Comment #3
berdirComment #4
berdirRe-rolled to use the same string as we do in pm_block_user.module. I also changed ! to %, as the username needs to be escaped afaik.
Comment #5
litwol commentedCommitted