Thanks for taking the initiative on this... it's a necessary step for the date repeat API. I just installed and created a repeating node and noticed a few things:
1) I got the following errors apparently associated with forward and search modules:
* user warning: Duplicate entry '3343' for key 1 query: INSERT INTO forward_statistics (nid, last_forward_timestamp, forward_count, clickthrough_count) VALUES (3343, 0, 0, 0) in mysite/sites/all/modules/forward/forward.module on line 484.
* user warning: Duplicate entry '3343' for key 1 query: INSERT INTO search_block VALUES ('3343', '0', '1') in mysite/sites/all/modules/search_block/search_block.module on line 193.
2) In the first instance of the repeating event location information did not show up (I'm using location module for this content type). This could be a problem, but not too bad.
3) Created sorting problems... In my view I have a teaser list sorting nodes by starting time, but with the node generator it appears that the starting time remains as the first instance of the event and the remaining nodes sort in a descending pattern - it usually makes sense to have them sorted ascending. Seems like the starting date needs to be over-ridden for each node so the sorting would work out consistently. I just noticed though that repeating nodes that I had created prior are not sorting correctly either though, so this may have more to do with the date module.
Other than that, it seems to be working great. As a UI tip though, it would be nice for the admin to declare whether drupal should 'Generate each date as a single node:' instead of the user. Just seems a bit confusing for the user.
Thanks again for this and hopefully someone with more programming skills can be a little more constructive in their comments than I have been.
Comments
Comment #1
vgriffin commentedIt appears that the problems had to do with the way nodes were being added. Instead of adding a newly-defined node, the new node contained leftover settings for other modules from the previous node. Pathauto behaved in a way that seems similar because of precisely that behavior and was fixed by building each new node from a copy made before the first call to node_submit. This allows each module (pathauto, forward, search_block, etc.) to start with fresh data for the new node.
6.x-2.x-dev fixes this problem.