[OGF needs to be compatible with OG on 2.x] Wierd error after OG/Views 2 Update

Anyone??

I have the same, shows up on forums with any comments in them.

I guess the column oa.is_public was removed in the latest version of OG, 6.x-2.0-rc1. That was the one I updated to just before this error appeared, and it changed a couple of tables.

I have also this error, and it appeared when I upgraded to the latest version of OG (6.x-2.0-rc1).
It is explained in the release notes (http://drupal.org/node/429998) that the DB schema was changed in this particular aspect:

Factor the is_public column out of og_ancestry table and into a new og_access_post table that is 'owned' by og_access module. Add primary key to og_ancestry to prevent duplicate entries.

So I think that the check that is done to get sure that the node is public should be changed to be aware of the new DB schema.

I'll only be fixing bugs against the 1.x branch of OG for the time being as my work commitments only require a working version of OG Forum against this branch . If anyone has the time to write a patch though to make the OG upgrade easy for OG Forum users that would be awesome!

Best, Paul

OK, I'm a Newbie to Drupal and not a coder, so I imagine this will sound stupid. I need to have all my OG forums and posts remain private, but I still want to retain the ability to have public forums for anonymous users as well.

In the og_forum.module I changed the og_ancestry reference to og_access_post. I ended up with the same error message, only it stated og_access_post where it used to read og_ancestry. I also updated to the latest dev versions of OG and OG Forum. I know nothing about database schemas, tables or keys - but if a workaround doesn't show up soon I'll take a stab at learning. I'm fine with modifying code if there's a pre-written sample of new code for me to use, but creating new code from scratch is still beyond me. If I miraculously stumble across a way to fix this I will post it here.

When I'm done with the site I'm building, I will definitely donate some time to writing some comprehensive and newbie-proof OG documentation.

Update May 6, 2009: I decided to simply revert to the previous version of OG; much easier than trying to fix the OG Forum module. Meanwhile I'm looking for a stable alternative to OG Forum.

Bill

around line 521 in the og_forum.module file change

$sql = "SELECT oa.nid, COALESCE(oa.is_public, 1) AS is_public FROM {node} n LEFT JOIN {og_ancestry} oa ON oa.nid = n.nid WHERE n.nid = %d";
to
$sql = "SELECT oa.nid, COALESCE(oa.og_public, 1) AS is_public FROM {og_access_post} oa WHERE oa.nid = %d";

only after upgrading to og 6.x-2.0-rc1

Error gone! Thanks for that.

Hey, Fantastic!

Thank you a lot! I had a website to move on production tomorrow, so you solved the ugly warning thing!

I hope Paul will think for when to change the code to give the module full compatibility with OG 2.0

Thanks again for the query batje.

beware, there are a few more places where this code is used in the module. will update later (we go live on friday :-) )

Worked for me too; many thanks batje!!! I hate to give up on the forums, I think they add a lot to the groups.

Lines 699 and 1028 also reference code similar to the patched code you fixed. If I could code I would try my hand at it, but I suspect the end result would be a broken module. :)

Thanks again!

As promised, its friday. So here is a patch that fixes the issue in all queries.

Please note, that there is now a dependency on the Organic groups access control Module. This patch does not update the .info file.

Please test before use, the other places where the query went off were pretty irregular, so i might have not actually hit them. (though i debugged the SQL in phpmyadmin.)

Reviewing patch

Automatically closed -- issue fixed for 2 weeks with no activity.

Sorry v2 was not active yet on my install, problem is there indeed gone.

Automatically closed -- issue fixed for 2 weeks with no activity.