Project:External Links
Version:6.x-1.9
Component:User interface
Category:support request
Priority:normal
Assigned:zoia
Status:needs review

Issue Summary

I use lightbox for displying images from my different projects into drupal. I would prefer not to get the message warning that is external link as far as it opens in the lightbox. Can this be controlled from the settings? or directly from the code?
thank you

Comments

#1

Could you provide a link to your site? I'm not sure how you can have a link that opens in lightbox but is external at the same time.

#2

Hey there. Thanks for the module. It really helps the usability for both the visitor and the site owner!

For my images that use lightbox, I have to set "rel" to "lightbox" in the link properties. Can you exclude links with that property?

#3

Perhaps the admin screen could be ammended with an "ignore links with attribute/values like this..."? That would also help with lightbox integration.

#4

Status:active» fixed

queue cleanup:

OP didn't respond to maintainers comment. I've extlink and lightbox2 installed and can't replicate as such at this time the issue is likely fixed.

#5

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

#6

Title:exclude image links» exclude lightbox links
Version:6.x-1.7» 6.x-1.9
Status:closed (fixed)» needs review

Attached patch, diff'ed against external-6.x-1.9, fixes the issue for me.

-Steve

AttachmentSize
external.js-exclude-lightbox.patch 625 bytes

#7

Title:exclude lightbox links» exclude external lightbox links

It is *external* lightbox links that we want to exclude from External Links' affects.

#8

Subscribing, greetings, Martijn

#9

Any reason not to apply this patch to the module?

-Steve

#10

In my opinion this patch is much too specific. The use-case already is very obscure (the link has to be external AND be opened in a Lightbox? Who does that?) and it wouldn't help users of any other *box implementations (colorbox/thickbox/highslide).

#11

Makes sense.

For those that want to open external links in lightbox links, new -p1 format patch attached.

AttachmentSize
external_exclude_lightbox_links-438918-4466364.patch 452 bytes