I use lightbox for displying images from my different projects into drupal. I would prefer not to get the message warning that is external link as far as it opens in the lightbox. Can this be controlled from the settings? or directly from the code?
thank you

CommentFileSizeAuthor
#12 external_exclude_lightbox_links-438918-4466474.patch460 bytessteveoliver
#11 external_exclude_lightbox_links-438918-4466364.patch452 bytessteveoliver
#6 external.js-exclude-lightbox.patch625 bytessteveoliver

Comments

quicksketch’s picture

quicksketch
he/him
commented

Could you provide a link to your site? I'm not sure how you can have a link that opens in lightbox but is external at the same time.

nomachinez’s picture

nomachinez commented

Hey there. Thanks for the module. It really helps the usability for both the visitor and the site owner!

For my images that use lightbox, I have to set "rel" to "lightbox" in the link properties. Can you exclude links with that property?

redijedi’s picture

redijedi commented

Perhaps the admin screen could be ammended with an "ignore links with attribute/values like this..."? That would also help with lightbox integration.

vm’s picture

vm commented
Status: Active » Fixed

queue cleanup:

OP didn't respond to maintainers comment. I've extlink and lightbox2 installed and can't replicate as such at this time the issue is likely fixed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

steveoliver’s picture

steveoliver commented
Title: exclude image links » exclude lightbox links
Version: 6.x-1.7 » 6.x-1.9
Status: Closed (fixed) » Needs review
StatusFileSize
new external.js-exclude-lightbox.patch625 bytes

Attached patch, diff'ed against external-6.x-1.9, fixes the issue for me.

-Steve

steveoliver’s picture

steveoliver commented
Title: exclude lightbox links » exclude external lightbox links

It is *external* lightbox links that we want to exclude from External Links' affects.

summit’s picture

summit commented

Subscribing, greetings, Martijn

steveoliver’s picture

steveoliver commented

Any reason not to apply this patch to the module?

-Steve

quicksketch’s picture

quicksketch
he/him
commented

In my opinion this patch is much too specific. The use-case already is very obscure (the link has to be external AND be opened in a Lightbox? Who does that?) and it wouldn't help users of any other *box implementations (colorbox/thickbox/highslide).

steveoliver’s picture

steveoliver commented
StatusFileSize
new external_exclude_lightbox_links-438918-4466364.patch452 bytes

Makes sense.

For those that want to open external links in lightbox links, new -p1 format patch attached.

steveoliver’s picture

steveoliver commented
Assigned: zoia » steveoliver
Status: Needs review » Closed (works as designed)
StatusFileSize
new external_exclude_lightbox_links-438918-4466474.patch460 bytes

Same as #11, but for 1.9.

Assigning to myself and settings closed (works as designed).

mfoda’s picture

mfoda commented

Well considering that the lightbox modules are becoming pretty popular would you consider #3's suggestion if it's feasible? I'm currently using colorbox D7 version and am running into the same problem.

mfoda’s picture

mfoda commented

Actually never mind. I thought only regexes can be used and not specific urls. Should have read around a bit more.

Thanks anyway