Closed (outdated)
Project:
Drupal core
Version:
6.x-dev
Component:
system.module
Priority:
Critical
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
20 Apr 2009 at 11:13 UTC
Updated:
2 Mar 2016 at 22:18 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
Anonymous (not verified) commentedComment #2
JeremyFrench commentedI have made the suggested change, a search for progess also showed up something in ahah.js which is also in the patch.
I don't know what effect this has on the front end, so it should probably be tested.
Comment #3
dries commentedCommitted to CVS HEAD. Thanks.
Comment #5
ahwebd commentedHello,
Can you also fix this in Drupal 6, It still exists in Drupal 6.16
Regards
Comment #6
ahwebd commentedThe typo is in both files:
modules/system/system-rtl.css
misc/ahah.js
Comment #7
ahwebd commentedI'm increasing issue priority, as it is forcing me (and for sure others) to hack and patch drupal core (which is really bad) just for a small typo
Please remove the bug in drupal 6
Regards
Comment #8
ahwebd commentedplz answer
Comment #9
ahwebd commentedPatch for 6.x-dev
Comment #10
ahwebd commentedComment #12
ahwebd commentedComment #13
JeremyFrench commented@ahwebd you'll need to name it ending in D6 for drupal 6 so the test bot ignores.
Also you need to wait for someone else to review.
Comment #14
ahwebd commentedIt is the same patch above that was already reviewed by the community, it is no more than correcting word "progress" that was written "progess"
Comment #15
ahwebd commentedComment #16
ahwebd commentedComment #17
ahwebd commentedCan someone tell why the status of the patch is saying "ignored" !
Comment #19
ahwebd commentedComment #20
ahwebd commentedComment #21
eric_a commentedCan someone tell why the status of the patch is saying "ignored" !
Your "typo_D6.patch" and "rtl_css_typo-D6.patch" patches aren't being tested with D7 core tests, unlike "typo.patch".
See http://drupal.org/node/332678.
Is the typo in these 2 files only and not in other files? Or is this class name consistently spelled wrong in all markup and LTR and RTL css files?
Comment #22
ahwebd commentedThe typo is only in the given files (ahah.js , system-rtl.css).
I can't understand how a bug as simple as this is hanging around from "April 20, 2009" !! this is unacceptable for a cms name like Drupal, where are you cvs people !
Comment #23
eric_a commentedYou need to get the (CSS) community to review this and sign this off. No maintainer will apply your patch and commit before that is done.
How exactly does the AHAH code fail in RTL?
How would killing the class name that's been around for so long affect code that only care about non AHAH scenario's? Would it be better to duplicate the declaration, rather then kill the one that's been around for so long?
Comment #24
ahwebd commentedWhen you press the "Attach" button in files attachments section of a node edit/add page it will jump from the right to the left side ! just because it will be disabled after pressing it (while uploading) and you have this bug:
".progess-disabled {float: right;}" instead of ".progress-disabled {float: right;}" in the rtl css file
This bug is forcing me (and for sure others) to hack and patch drupal core (which is really bad) just for a small typo :(
Comment #25
eric_a commentedThere are ways in Drupal to manipulate presentation and behaviour other than hacking core, but it would still be nice if this issue got a little more attention.
Fixing presentation is much easier than fixing behaviour, so I suggest you focus this issue on the latter. What are the behavioral problems here? I assume it must be something with the button not being disabled/ re-enabled in uploading scenarios the way it should. (The attach button not being re-enabled would be a nightmare scenario if you needed to upload more than one file.)
Please describe some more. (And change the title to reflect the broken behaviour and the consequences you observe.)
Thanks!
Comment #26
ahwebd commentedthe bug is clear, waiting for someone to look at it.
@Eric_A: not all people are professional on coding, and people reporting bugs don't necessarily provide patches and resolve issues, there need to be drupal pros to do this, ignoring bugs for so long is really surprising!
Comment #27
ahwebd commentedComment #28
dpearcefl commentedIs this issue fixed in the latest D6? is there any interest in pursuing this issue?