===================================================================
--- /var/www/d6.old/modules/system/system-rtl.css
+++ /var/www/d6/modules/system/system-rtl.cs
@@ -74,7 +74,7 @@
.progress .percentage {
float: left;
}
-.progess-disabled {
+.progress-disabled {
float: right;
}
.ahah-progress {

Comments

Anonymous’s picture

Version: 6.9 » 7.x-dev
JeremyFrench’s picture

Assigned: Unassigned » JeremyFrench
Status: Active » Needs review
StatusFileSize
new1.01 KB

I have made the suggested change, a search for progess also showed up something in ahah.js which is also in the patch.

I don't know what effect this has on the front end, so it should probably be tested.

dries’s picture

Status: Needs review » Fixed

Committed to CVS HEAD. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

ahwebd’s picture

Version: 7.x-dev » 6.16

Hello,

Can you also fix this in Drupal 6, It still exists in Drupal 6.16

Regards

ahwebd’s picture

Status: Closed (fixed) » Active

The typo is in both files:

modules/system/system-rtl.css
misc/ahah.js

ahwebd’s picture

Assigned: JeremyFrench » Unassigned
Priority: Normal » Critical

I'm increasing issue priority, as it is forcing me (and for sure others) to hack and patch drupal core (which is really bad) just for a small typo

Please remove the bug in drupal 6

Regards

ahwebd’s picture

plz answer

ahwebd’s picture

Version: 6.16 » 6.x-dev
StatusFileSize
new788 bytes

Patch for 6.x-dev

ahwebd’s picture

Status: Active » Reviewed & tested by the community

Status: Reviewed & tested by the community » Needs work

The last submitted patch, typo.patch, failed testing.

ahwebd’s picture

Status: Needs work » Reviewed & tested by the community
StatusFileSize
new748 bytes
JeremyFrench’s picture

Status: Reviewed & tested by the community » Needs work

@ahwebd you'll need to name it ending in D6 for drupal 6 so the test bot ignores.

Also you need to wait for someone else to review.

ahwebd’s picture

Status: Needs work » Needs review
StatusFileSize
new748 bytes

It is the same patch above that was already reviewed by the community, it is no more than correcting word "progress" that was written "progess"

ahwebd’s picture

ahwebd’s picture

StatusFileSize
new748 bytes
ahwebd’s picture

Can someone tell why the status of the patch is saying "ignored" !

Status: Needs review » Needs work

The last submitted patch, typo.patch, failed testing.

ahwebd’s picture

Status: Needs work » Needs review
StatusFileSize
new748 bytes
ahwebd’s picture

StatusFileSize
new748 bytes
eric_a’s picture

Can someone tell why the status of the patch is saying "ignored" !
Your "typo_D6.patch" and "rtl_css_typo-D6.patch" patches aren't being tested with D7 core tests, unlike "typo.patch".
See http://drupal.org/node/332678.
Is the typo in these 2 files only and not in other files? Or is this class name consistently spelled wrong in all markup and LTR and RTL css files?

ahwebd’s picture

The typo is only in the given files (ahah.js , system-rtl.css).

I can't understand how a bug as simple as this is hanging around from "April 20, 2009" !! this is unacceptable for a cms name like Drupal, where are you cvs people !

eric_a’s picture

You need to get the (CSS) community to review this and sign this off. No maintainer will apply your patch and commit before that is done.

How exactly does the AHAH code fail in RTL?
How would killing the class name that's been around for so long affect code that only care about non AHAH scenario's? Would it be better to duplicate the declaration, rather then kill the one that's been around for so long?

ahwebd’s picture

How exactly does the AHAH code fail in RTL?

When you press the "Attach" button in files attachments section of a node edit/add page it will jump from the right to the left side ! just because it will be disabled after pressing it (while uploading) and you have this bug:
".progess-disabled {float: right;}" instead of ".progress-disabled {float: right;}" in the rtl css file

This bug is forcing me (and for sure others) to hack and patch drupal core (which is really bad) just for a small typo :(

eric_a’s picture

There are ways in Drupal to manipulate presentation and behaviour other than hacking core, but it would still be nice if this issue got a little more attention.

Fixing presentation is much easier than fixing behaviour, so I suggest you focus this issue on the latter. What are the behavioral problems here? I assume it must be something with the button not being disabled/ re-enabled in uploading scenarios the way it should. (The attach button not being re-enabled would be a nightmare scenario if you needed to upload more than one file.)

Please describe some more. (And change the title to reflect the broken behaviour and the consequences you observe.)

Thanks!

ahwebd’s picture

the bug is clear, waiting for someone to look at it.

@Eric_A: not all people are professional on coding, and people reporting bugs don't necessarily provide patches and resolve issues, there need to be drupal pros to do this, ignoring bugs for so long is really surprising!

ahwebd’s picture

Title: typo in the rtl css file » "Attach" button in files attachments section of a node edit/add page jumps from the right to the left side in RTL languages
dpearcefl’s picture

Is this issue fixed in the latest D6? is there any interest in pursuing this issue?

Status: Needs review » Closed (outdated)

Automatically closed because Drupal 6 is no longer supported. If the issue verifiably applies to later versions, please reopen with details and update the version.