There are a few base element resets in this theme that don't make a whole lot of sense to have in there:

b, strong {
  font-weight: bold;
}
i, em, u {
  font-style: italic;
}
u {
  text-decoration: none;
}

u with a text-decoration of none, in particular, is just weird and has caused at least some folks to pull out their hair trying to figure out why things were displaying oddly. I think we should remove these and let them stay at defaults.

CommentFileSizeAuthor
#3 foundation_element_reset_2.patch5.51 KBTresler
#2 foundation_element-reset_439428-1.patch812 bytesadd1sun

Comments

add1sun’s picture

add1sun commented

Also, setting ALL headings to the same size, and 100% at that?

h1, h2, h3, h4, h5, h6 {
  margin-top: 10px;
  margin-bottom: 0px;
  font-size: 100%;
}
add1sun’s picture

add1sun commented
Status: Active » Needs review
StatusFileSize
new foundation_element-reset_439428-1.patch812 bytes

Attaching a patch that cleans these out.

Tresler’s picture

Tresler commented
StatusFileSize
new foundation_element_reset_2.patch5.51 KB

Patch applies clean and works as advertised.

I did notice that a lot of the whitespace was odd. It looked like the grouping of common selectors was not being separated by a space between rules, which, for me made it difficult to read.

I went through style.css and cleaned it up vis-a-vis this: http://drupal.org/node/302199

Only then did I realize I'd already applied add1sun's patch, so here are the two patches combined. I would normally make this two separate patches. but here is hoping a combined patch is better than nothing.

markhalliwell’s picture

markhalliwell
Primary language English
commented
Issue summary: View changes
Status: Needs review » Closed (outdated)

This project has been repurposed and this issue is no longer relevant.

markhalliwell’s picture

markhalliwell
Primary language English
commented
Project: Foundation »
Version: 6.x-1.x-dev »

Project: » Lost & found issues

This issue’s project has disappeared. Most likely, it was a sandbox project, which can be deleted by its maintainer. See the Lost & found issues project page for more details. (The missing project ID was 2925308)