As #439602: Remove openid_cp_field dependency and move content_profile parts into openid_cp_field is on it's way. openid_cp_field needs to implement that new hook and does the job of adding the user profile node according to the mapping.
The code is mainly from openid_client_ax
Please don't commit yet. Needs more work.

CommentFileSizeAuthor
#8 439622_hook_openid_client_ax.patch2.65 KBalex_b
#6 openid_cp_field_client_side_mapping_code.patch2.67 KBaron novak
#5 openid_cp_field_client_side_mapping_code.patch2.67 KBalex_b
#3 openid_cp_field_client_side_mapping_code.patch2.78 KBaron novak
#1 openid_cp_field_client_side_mapping_code.patch2.59 KBaron novak
openid_cp_field_client_side_mapping_code.patch2.59 KBaron novak

Comments

aron novak’s picture

aron novak
Primary language Hungarian
Location Hungary, Budapest
commented
StatusFileSize
new openid_cp_field_client_side_mapping_code.patch2.59 KB
aron novak’s picture

aron novak
Primary language Hungarian
Location Hungary, Budapest
commented
Status: Needs work » Needs review

Please do not commit it yet, needs more testing.
This patch is just as the same in the previous post, but fixes a bug (it created the profile nodes again and again at the logins)

aron novak’s picture

aron novak
Primary language Hungarian
Location Hungary, Budapest
commented
StatusFileSize
new openid_cp_field_client_side_mapping_code.patch2.78 KB

Here is a newer version.
Please do not commit it yet, still needs more testing.
It fixes that the module created empty profiles sometimes (when the provider do not get back with any data but the mapping is defined at the client)
Empty profile is definitely ugly.

alex_b’s picture

alex_b commented
Title: Being an implementor of openid_client_ax() » Make openid_cp_field an implementer of hook_openid_client_ax()

Better title.

alex_b’s picture

alex_b commented
StatusFileSize
new openid_cp_field_client_side_mapping_code.patch2.67 KB

Minor tweaks to comments. Can't confirm that this is working yet: #441050: Profile not created.

aron novak’s picture

aron novak
Primary language Hungarian
Location Hungary, Budapest
commented
StatusFileSize
new openid_cp_field_client_side_mapping_code.patch2.67 KB

A bug is fixed: if the user had the admin node right, uid become empty (so the node was not used as the profile)

alex_b’s picture

alex_b commented
Assigned: Unassigned » alex_b

Patch does not apply atm. working on it.

alex_b’s picture

alex_b commented
StatusFileSize
new 439622_hook_openid_client_ax.patch2.65 KB
alex_b’s picture

alex_b commented
Assigned: alex_b » Unassigned
Status: Needs review » Reviewed & tested by the community

Darren: I just tested - this is RTBC.

It may need some follow up tweaks but this will be much easier once this is in.

darren.ferguson’s picture

darren.ferguson commented

Alex, patch failed to commit

[darren@myhost openid_cp_field]$ patch -i openid_cp_field_simplier_ui_0_0.patch
patching file openid_cp_field.css
Reversed (or previously applied) patch detected! Assume -R? [n] y
patching file openid_cp_field.module
Reversed (or previously applied) patch detected! Assume -R? [n] y
Hunk #4 succeeded at 119 with fuzz 1.
Hunk #5 FAILED at 153.
Hunk #6 FAILED at 165.
2 out of 7 hunks FAILED -- saving rejects to file openid_cp_field.module.rej

alex_b’s picture

alex_b commented

Darren, I just applied to latest D6 branch with

a:openid_cp_field ab$ patch -p0 < 439622_hook_openid_client_ax.patch 
patching file openid_cp_field.module
a:openid_cp_field ab$

and it works fine...

darren.ferguson’s picture

darren.ferguson commented

Okay committed this time to the cvs repository

darren.ferguson’s picture

darren.ferguson commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.