Follow up issue to #428932: Improve mapping UI, support provider and client.

This patch cleans up some language on the mapping user interface http://skitch.com/alexbarth/bcc9q/profile-localhost

Further:

1) Let's stick AX and SREG OpenID fields into one select box http://skitch.com/alexbarth/bcpyg/profile-localhost - this would address the submit button issue ('Add' can be only used once) and it would be consistent with the table that represents the mapping.
2) Use AX: and SREG: as a prefix, not a postfix in brackets (SReg). E. g. "Sreg: Alias" instead of Alias (SReg). This allows us to naturally sort OpenID field names while keeping them consistently grouped.

CommentFileSizeAuthor
#8 openid_cp_field_ui_desc.patch4.5 KBalex_b
#7 openid_cp_field_ui_desc.patch5.12 KBaron novak
#4 openid_cp_field_simplier_ui.patch6.35 KBaron novak
#2 openid_cp_field_simplier_ui.patch6.35 KBaron novak
ui_review.patch3.28 KBalex_b

Comments

alex_b’s picture

alex_b commented

Addition: Rename "OpenID Content Profile Field mapping" to "OpenID field mapping" shorter, simpler, clear in context.

aron novak’s picture

aron novak
Primary language Hungarian
Location Hungary, Budapest
commented
Status: Active » Needs review
StatusFileSize
new openid_cp_field_simplier_ui.patch6.35 KB

Here is the patch for making the UI cleaner and simplier.

darren.ferguson’s picture

darren.ferguson commented

Aron

can you re-do this patch off what we have in CVS now please? It failed as shown below:

[openid_cp_field]$ patch -i openid_cp_field_simplier_ui_0.patch
patching file openid_cp_field.css
patching file openid_cp_field.module
Hunk #2 FAILED at 93.
1 out of 7 hunks FAILED -- saving rejects to file openid_cp_field.module.rej

aron novak’s picture

aron novak
Primary language Hungarian
Location Hungary, Budapest
commented
StatusFileSize
new openid_cp_field_simplier_ui.patch6.35 KB

Thanks, I rerolled the patch.

darren.ferguson’s picture

darren.ferguson commented
Status: Needs review » Fixed

Aron, patch is applied to cvs

alex_b’s picture

alex_b commented

Aron: some of the changes in my original post got dropped in #2 - can you review that?

aron novak’s picture

aron novak
Primary language Hungarian
Location Hungary, Budapest
commented
Status: Fixed » Needs review
StatusFileSize
new openid_cp_field_ui_desc.patch5.12 KB

#6: yep, sorry, I somehow did not noticed the attached file in the first post :)
Here is a new and added some more explanation.

alex_b’s picture

alex_b commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new openid_cp_field_ui_desc.patch4.5 KB

Tweaked out mapping in code indicators. Reviewed and tested.

Darren - this is RTBC.

darren.ferguson’s picture

darren.ferguson commented
Status: Reviewed & tested by the community » Fixed

Alex this is now committed into the repository per your instructions above.

alex_b’s picture

alex_b commented

Awesome, thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.