This patch fixes displaying of flexinode date/time form fields. Without this patch the form is splited to multiple lines and each subfield (textboxes for day, year, hour, ...) is rendered as block (display:block) and has width of 95%.

Comments

moshe weitzman’s picture

Title: Flexinode date/time field form in not displayed properly. » fix css - container-inline
jjeff’s picture

Priority: Normal » Critical
StatusFileSize
new630 bytes

I was having a similar problem where form labels were imposing their block display even though they were in the container-inline element.

This patch targets both divs and labels so that labeled form elements will appear inline as well. It also moves the .container-inline declaration down to the bottom of the CSS so that it won't succeeded by the ".form-element label" declaration.

jjeff’s picture

StatusFileSize
new27.76 KB

Here's an illustration of inline form elements after this patch has been applied.

tangent’s picture

Version: 4.7.0-beta2 » x.y.z
Priority: Critical » Normal

This issue probably requires some discussion. I'm changing the priority though because it isn't really critical.

nickl’s picture

.container-inline div is now defined in modules modules/system/system.css

.container-inline div {
  display: inline;
}

.form-text is now defined in modules/node/node.css

.node-form .form-text {
  display: block;
  width: 95%;
}

The first patch suggests:

.container-inline .form-text {
  display: inline;
  width: auto;
}

The second patch only changes:

.container-inline div, .container-inline label {
  display: inline;
}

Not sure if this is to be marked fixed but IMO this is not a bug.
Left Category and Status to be changed by next reviewer.

Steven’s picture

Status: Needs review » Fixed

I merged the two patches. The fix is to have .container-inline nullify only the exact items which we change (node form text fields, non-option labels, ...).

Anonymous’s picture

Status: Fixed » Closed (fixed)