I'm not sure it's the proper place to post it but looking the js error, i hope itmightbe.
On my site, i use many modules:
-a version of cck which use the #119102: Combo field - group different fields into one (the last rconstantine tarball)
-smileys
- BUEeditor
- fivestar

For the comments, i use a separate page (because i use advanced forum), and whan i want to adda comment to a node, i encounter the following error: 

$.ui.tabs is not a constructor
(?)()()ui.tabs.js?x (ligne 28)
(?)()(Object length=1 0=ul prevObject=Object jquery=1.2.6, function(), undefined)jquery.j...e3Q%3D%3D (ligne 1)
(?)()(function(), undefined)jquery.j...e3Q%3D%3D (ligne 1)
tabs()()ui.tabs.js?x (ligne 23)
tabs()(Document 670#comment-form)tabs.js?x (ligne 23)
(?)()()drupal.js?x (ligne 42)
(?)()(Object, function(), undefined)jquery.j...e3Q%3D%3D (ligne 1)
attachBehaviors()(Document 670#comment-form)drupal.js?x (ligne 41)
(?)()()drupal.js?x (ligne 276)
(?)()()jquery.j...e3Q%3D%3D (ligne 1)
(?)()()jquery.j...e3Q%3D%3D (ligne 1)
(?)()([function(), function(), function()], function(), undefined)jquery.j...e3Q%3D%3D (ligne 1)
(?)()()jquery.j...e3Q%3D%3D (ligne 1)
[Break on this error] new $.ui.tabs(this, args[0] || {});

the effects are :
-the fivestar widget doesn't work properly
- the bueditor doesn't appear

You can see it http://www.afterfoot.com/comment/reply/670#comment-form
You don't need an account be able to post comments

thanks for your help. If you need more information, please ask.

CommentFileSizeAuthor
#13 tabs-without-jqueryUI.png138.77 KBRoulion
#8 tabs.module.patch1.01 KBeugenmayer

Comments

Roulion’s picture

Roulion commented

after testing, the problem looks to come from the smiley module... If i disable it, the comments woks fine (i have thue BUEditor and the fivestar widget working)

rsantiag’s picture

rsantiag commented

The same problem happen to me but using cck date field w popup. If I don´t use popup, the form works properly.

Anonymous’s picture

Anonymous (not verified) commented

I'm having the same problem, too.

I'm using jQuery UI already on my site, so I took a chance and hacked into tabs.module to call jquery_ui_add('ui.tabs') instead of loading the module's ui.tabs.js file. This fixed the issue for me so far.

I wonder if #275760: Introduce dependency on jQuery UI module could get some resolution, this issue would go away?

rsantiag’s picture

rsantiag commented

Thanks bangpound, I'll try your tip.

Ricardo

UPDATE: Solved, it works!!!

Roulion’s picture

Roulion commented

bangpound, excuse me, can you tell me what you change?

in the module I have line 180
drupal_add_js($path . '/ui.tabs.js');

nedjo’s picture

nedjo
he/him/his
Primary language English
commented
Status: Active » Fixed

Presumably fixed by updating the ui.tabs code and using jquery_ui if available.

Roulion’s picture

Roulion commented
Status: Fixed » Active

Hi,
unfortunately not.. When i click on smileys, they don't appear in the comment textarea

eugenmayer’s picture

eugenmayer commented
StatusFileSize
new tabs.module.patch1.01 KB

i cant see the patch has been applied to the current stable version ( 6.1.1.)

Iam appending the patch below. With that, you can use tabs and e.g. hierchical select..

nedjo’s picture

nedjo
he/him/his
Primary language English
commented

@EugenMayer: The patch was applied. Please review the code again in the stable release.

@Roulion: are you using today's stable release? The particular issue with smileys and and various other modules is not one I'm easily able to investigate.

Roulion’s picture

Roulion commented

Hi, i was using the aug, 19th dev version (and 1.1 too), i'll try with the aug 20th version and tell.

With the aug 19th version, all my tabs desappear and are replaced with anchor links, as you can see here
On the tabexample page no tabrs appear.
(i use the latest jQuery UI 1.x-devversion and then latest jQuery Update 1;x-dev version too). I hope it will be fixed

eugenmayer’s picture

eugenmayer commented

Nedjo i dont need to review the stable version, as iam using it and it was not there :)

I could nout / would not added those line, if they would have been present

nedjo’s picture

nedjo
he/him/his
Primary language English
commented
Title: Adding comments: $.ui.tabs is not a constructor » Incompatible with jquery_update

@EugenMayer: This is the stable version: http://cvs.drupal.org/viewvc.py/drupal/contributions/modules/tabs/tabs.m.... I tried downloading again and confirmed that this is the version in the tarball. Could you have another look? Thanks.

@Roulion: likely the issue is with jquery_update, which I haven't tested with. Are you using the 1.7 version of the jQuery UI library?

Changing issue title on the assumption that this is related to jquery_update. We can change back if not.

Roulion’s picture

Roulion commented
StatusFileSize
new tabs-without-jqueryUI.png138.77 KB

@nedjo

yes i use the 1.7.1 version of JQuery
and the 1.2.6 version of jquery Update

I used the latest dev version (aug 20th), and It doesn(t work.
If i desactivate the jqueryUI module, the tabs doesn't display correctly (see pictures)

EDIT : on my site, i downgraded the jQuery tabs to 1.0 and cck fieldgroup tabs, to aug 17th dev version and may tabs works fine.
I hope you'll find a solution.. thank in advance for your work

KoCo’s picture

KoCo commented

I added the patch from #8, and it did the trick.
I was also having problems with a date field.
The cause lies with using the jquery.ui module in combination with another module possibly loading the same scripts.
Firebug guided me to the files in question, and thus the modules involved.

thx,
Koen

nedjo’s picture

nedjo
he/him/his
Primary language English
commented
Status: Active » Fixed

If the patch from #8 fixed this, I assume it's fixed in stable.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.