reminde me did not work with drupal 4.7
mvoehringer - January 9, 2006 - 20:47
| Project: | Remindme |
| Version: | HEAD |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | active |
Description
i tried to install remindme on the new 4.7.0-beta2, put when i open the settings page i only see an empty page :(
#1
this module isn't yet updated for 4.7. Patches welcome.
#2
I'm afraid I don't have time to learn about creating and submitting patches, but this worked fine for my set up with 4.7.
I simply used the form updater at http://www.lullabot.com/formupdater to replace the old form declarations by pasting the new forms api over the top of the old.
I also changed a couple of $outputs to print or something like that!
#3
Given the attachment above I've changed the status to 'code needs review'. That should probably read 'code needs accepting and testing by somebody a bit more in the know than me!' ;-)
#4
Thanks, Sverre, I've worked a bit more on it and committed the changes. I will not yet branch for 4.7 as some work needs to be done, mainly a .install file and some more form changes. Mainly testing of course.
#5
No problems Killes, I'll look forward to the 4.7 version, and will help test where possible. This module is an excellent add on feature for any online calendar! Thank you and well done.
Just a note for anybody that is interested, I also discovered with a bit more testing that the sql query for getting and sending reminders also needed updating. I added a db_rewrite_sql() around the query and all now seems okay.
Also for any flexinode users; if you use flexinode for events like me, look for the following code at about line 35:
if ($node->type == 'event' && user_access('set reminders')) {and change it to:
if ($node->type == 'flexinode-1' && user_access('set reminders')) {Substitute the 1 in 'flexinode-1' as appropriate.
#6
I've committed a version which includes these changes. Please try it.
#7
remindme.module,v 1.28 2006/05/28 01:18:31 killes Exp
Good News is that there is now a RemindMe! link in the event nodes. When clicked the link leads to the RemindMe setup page where times prior to the event can be selected for reminders to be sent. This page appears to work correctly as no errors are triggered when the reminder is saved.
Unfortunately, the RemindMe! menu item triggeres this error:
Fatal error: [] operator not supported for strings in /drupal/modules/remindme/remindme.module on line 184
I am still testing to see if the reminders are actually sent by the system and will report back.
#8
pcwick, a patch for that is here http://drupal.org/node/65923
#9
Thank you Timotheos! I missed that one. The menu item now works. No error.