If a custom masthead image is selected and the header height is specified, the image is used, but the height of the header is not used.
The bug can be easily fixed adding:

  <?php if (theme_get_setting('mastheadfixedfluid') ) {

height: print theme_get_setting('mastheadfixedfluid') px;
<? } ?>
?>

after line 143 on page.tpl.php:

  background-image:url('/<?php print theme_get_setting('masthead_bg_path') ?>');

Comments

finex’s picture

finex commented

I'm sorry, the pasted code is not displayed correctly with the "php" delimiter. The following is the right bug report:

If a custom masthead image is selected and the header height is specified, the image is used, but the height of the header is not used.
The bug can be easily fixed adding:

  <?php if (theme_get_setting('mastheadfixedfluid') ) { ?>
    height:<?php print theme_get_setting('mastheadfixedfluid') ?>px;
  <? } ?>

after line 143 on page.tpl.php:

  background-image:url('/<?php print theme_get_setting('masthead_bg_path') ?>');
Anonymous’s picture

Anonymous (not verified) commented

Hi,

Thank you for the correction, I can confirm that it works.

Question:
I do not know PHP but I saw the following code and removed it from the page.tpl.php and it seemed to remove the text from overlapping the masthead. Would this modification affect other code elsewhere?

 <?php if ($site_name): ?>
          <h1 class='site-name'> <a href="<?php print $base_path ?>" title="<?php print t('Home'); ?>"> <?php print $site_name; ?> </a> </h1>
        <?php endif; ?>

Thanks

jrglasgow’s picture

jrglasgow commented

@FiNeX

your fix in #1 has been put in CVS and will appear in version 6.x-1.4

jrglasgow’s picture

jrglasgow commented
Status: Needs review » Fixed
finex’s picture

finex commented

Good, thanks for it :)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.