When getting the attributes to request, i used a confusing variable name.

CommentFileSizeAuthor
openid_client_ax_fix_confusing_variable_name.patch1.7 KBaron novak

Comments

aron novak’s picture

aron novak
Primary language Hungarian
Location Hungary, Budapest
commented

The first post is too laconic.
So when we get the attributes from openid_cp_field (or from other implementor, via a hook) what we will request from the provider site, the variable that stored the list of attributes was called $mapping, although it contained something else. It's really confusing because $mapping is used in definitely different meanings. And that variable does not contain the mapping itself.

alex_b’s picture

alex_b commented
Status: Needs review » Reviewed & tested by the community

$attributes is better than $mapping in this context. RTBC from my point of view.

alex_b’s picture

alex_b commented
Assigned: aron novak » Unassigned

This is in Darren's court now.

darren.ferguson’s picture

darren.ferguson commented

$attributes is good with me also, since it is attribute exchange :-)

alex_b’s picture

alex_b commented
Status: Reviewed & tested by the community » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.