I don't know if this causes problems in Drupal 7, but with simpletest on Drupal 6, if module_exists() is called during set-up, the result is wrong because the static variable is not refreshed until after the modules are installed.

CommentFileSizeAuthor
#5 440824-module-reset.patch908 bytesboombatower
drupal_web_test_case.php_.patch855 bytesdarren oh

Comments

darren oh’s picture

darren oh
Primary language English
Location Lakeland, Florida
commented

Patch for Drupal 6 at http://drupal.org/node/440836.

cburschka’s picture

cburschka
they
commented
Title: Error when installation uses module_exists() » Reset module_list() and module_implements() on test setup.

Seems to be in order for now, but be aware that module.inc is going to be converted to the static caching API, and these calls may then have to be replaced with drupal_static_reset('module_list') etc. Depending on whether the $reset parameter is removed from these, which is still debated.

The issue to follow is #422370: Revisit and convert mail.inc, module.inc, pager.inc to use static caching API.

Status: Needs review » Needs work

The last submitted patch failed testing.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

This patch fixes the errors a lot of us are seeing in D6 and D7 with exceptions with tables not found (cache_update, etc).

boombatower’s picture

boombatower commented
Status: Needs work » Needs review
StatusFileSize
new 440824-module-reset.patch908 bytes

Re-roll.

boombatower’s picture

boombatower commented

Try out: #472684: Install non-default modules one at a time to ensure proper module list is maintained during installation hooks I think it is the parent bug.

darren oh’s picture

darren oh
Primary language English
Location Lakeland, Florida
commented

The root problem is that the module list from the previous test is being used during the setup the next test. This patch actually fixes the problem, rather than working around it.

P.S. I now see that the other issue fixes the install system rather than the testing system, so it's not a workaround. My main concern was to make the testing system work the same way as enabling modules on the module administration page. That patch would do that.

darren oh’s picture

darren oh
Primary language English
Location Lakeland, Florida
commented
Status: Needs review » Closed (duplicate)

Since the other patch appears to have a good chance of being committed, I'm setting the status of this issue to duplicate.

boombatower’s picture

boombatower commented

This patch does not fix both problems, but the other patch does so lets stick with that one.

kenorb’s picture

kenorb commented

Duplicate of what?
I'm lost.