Posted by itaine on April 21, 2009 at 10:24pm
Jump to:
| Project: | Terms of Use |
| Version: | 6.x-1.9 |
| Component: | Miscellaneous |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (duplicate) |
Issue Summary
Simple feature request to have an option to have the link to terms/policies page to open in a new(_blank) or parent (_self) window. Someone mentioned it in a different issue and offered a "quick and dirty" patch of code to accomplish it. Just making a formal request for it.
Comments
#1
subscribe
#2
+1
#3
I suggest to give it a higher priority since that improve usability remarkably.
#4
This is workaround I'm using before the issue is resolved:
1. Create the TOU page
2. Create a jumper page, title it as Agreement or the like. Include a line like "I have read and understand TOU", linking the text to the above real TOU page, with target="_blank".
3. Set the jumper page as the TOU page in the module
4. Don't use @link - then the content of jumper page will be show and user can click it for TOU content, in a new window.
Bad to admin but perfect to end users :-)
The demo: http://www.translia.com/user/register
#5
I'm not sure why a patch would be necessary? Read the README.txt file. You can theme the terms of use anyway you like in template.php.
#6
Thanks for the tips on theme. That's good but an option on admin UI would be better? Anyway, the theme solution is good enough.
#7
Hello,
I've read the README.tx and although I added these lines at the end of my template.php it's not working
function THEMENAME_terms_of_use($terms, $node) {$output = '<div id="terms-of-use" class="content clear-block">';
$output .= t('Terms of use of this page are available !here.', array('!here' => l('here', 'node/'."$node->nid")));
$output .= '</div>';
return $output;
}
Do I have to do something else? Am I doing something wrong? (I'm using ToU v 6.10)
Thanks
#8
@ c-c-m
Change THEMENAME on the first line to your theme name and then clear cache.
#9
Oops, Thank you very much for your info! I didn't know that
#10
subscribe
#11
+1
It should default to open in a new browser. It really doesn't make sense for someone to fill out their user registration and then click the link and have it loose everything they just filled out. I can't name a top site that has the terms open in the same page like this.
#12
Thanks askit, you're solution (#4) was tops!!
#13
I think both approaches (#1/_blank vs. #4/jumper page) are viable for different use cases, and both should be supported.
I used jumper page to show Terms in a lightbox. Maybe for #1 it makes sense to allow lightbox use also, so it becomes a selector with a list of options. I did such a selector for iTweak Upload module.
I will see if it is easy to include in my combined patch #759064: Combined patch to address multiple issues and feature requests.
#14
Duplicate of #768636: Open term of use in new window for better usability
#15
When you use #4 suggestion, it puts the check box at the bottom of the content, and not before, and creates a longer div, no matter how short your jumper node is. It's messy.
#16
you can say that again
#17
nice topic i like it
Turkish Translation