Replace participant select

Is it possible to make this a checkbox option? the textfield by default, but if checked, use the old method of showing the full list? Or would that make things a little too complicated?

I have tested this patch many times and it seems to work well, but leaving at cnr for now as the original post mentions adding more comments.

Actually, this no longer applies.

Also:

+  list($messages['recipients'], $invalid) = _privatemsg_parse_userstring($form_state['values']['recipients']);

should be

+  list($message['recipients'], $invalid) = _privatemsg_parse_userstring($form_state['values']['recipient']);

Otherwise sending new messages breaks. (remove the two extra s's)

Works as expected and the noted problems have been fixed.

EDIT - If there was one niggle, I would have the sql and the sql_alter functions documented. I always need to find what calls them to see what their purpose is... but that can be done separately en masse for all the others too.

as per nbz's "EDIT - ..."

I think it would be good to return this to rtbc, and cover the sql functions all in one go. I have created #454832: Document sql query definitions. as an all in one issue queue - but I will leave the status of this as is to let litwol decide.

Despite the fact that i advocate smaller patches, that does not always apply to documentation. It besides many other benefits, it also helps me review patches better/faster when there's an abundancy of documentation.

Works, documentation added.

Minor change on line 324 in privatemsg_filter

from

       $string .= $author->name . ', ';

to

      $string = isset($string)? $string . $author->name . ', ' : $author->name . ', ';

On first loop $string does not exist and it throws a notice.

Friendly reminder everyone to turn on your php E_NOTICE & $_ALL when developing.

works as expected (the fix in patch 5 is different to the one proposed in patch 4, but should work as well if not better as a condition is not being evaluated on every roll of a loop).

Voila ;)