A followup on #439500: files that don't need conversion by whoastdev

The remaining problem however is that files that don't get converted also don't get any snapshot images.

I would like FFmpeg Converter to handle snapshots the same for all video files, regardless if they will be converted or not. I think the way to do that is to separate out the snapshot generation from the conversion jobs and make that a "job" of its own. That way, a node could have either two jobs – one for converting the video and one for generating snapshots – or just the snapshot generation.

CommentFileSizeAuthor
#5 ffmpeg_converter_441348.patch13.69 KBzoo33
#4 patch.txt11.17 KBsndev
#2 patch.txt49.38 KBsndev

Comments

sndev’s picture

sndev commented

After looking at the ffmpeg_conversion code a little more extensively, I was going to suggest the same thing. I'll work on some code tomorrow and get back to you about my findings.

sndev’s picture

sndev commented
StatusFileSize
new patch.txt49.38 KB

This a bit late, but we have been extra busy here at Whoast.

I split up the ffmpeg_convert_convert_filefield function into two functions (1 for file conversion and another for snapshots) and cleaned up the code based on the coder modules suggestions. The patch is against CVS head.

zoo33’s picture

zoo33 commented

OK, so this is the same patch as in #442166: Destination Token error

Please see my comments there. Thanks for this by the way!

sndev’s picture

sndev commented
StatusFileSize
new patch.txt11.17 KB

This patch is against head and doesn't use hide_original functionality. The only added functionality is http://drupal.org/node/442166

zoo33’s picture

zoo33 commented
Status: Active » Needs review
StatusFileSize
new ffmpeg_converter_441348.patch13.69 KB

I've done some more work on this patch. There are now two types of jobs: conversion and snapshot generation. The good thing is that they both don't have to be processed during the same cron run. It's also an architecture which is better suited for adding the possibility of running multiple conversions on the same original file, which is something I'd like to implement.

I could really use some help testing this though. There are lots of things that might break...

zoo33’s picture

zoo33 commented
Status: Needs review » Postponed

We're now working on a new approach for this module, where we'll be using separate file fields for different formats, and handle conversion between them with Rules. I want snapshot generation to work like any other conversion, which kind of makes this issue outdated. I'm marking it as postponed for now. If I get good reviews and tests for this or another patch I'll consider committing it.