Header parsing bugs

AlexisWilke - April 22, 2009 - 17:37
Project:Webmail Plus
Version:6.x-1.x-dev
Component:Code
Category:bug report
Priority:critical
Assigned:Unassigned
Status:patch (to be ported)
Description

Hi there,

As I was looking a little closer in your module I found several bugs in your header parsing:

  • preg_match() to test for the tabs, only a tab at the very beginning need to be taken in account, not any tag
  • Possible use of $key before it is defined (in case there were a tab on the very first line, also unlikely, you never know!)
  • htmlentities() used on $value but not on $line when a tab is found

I'm attaching a patch.

Thank you.
Alexis Wilke

AttachmentSize
webmail_plus-6.x-1.4-parse-header.patch452 bytes
 
 

Drupal is a registered trademark of Dries Buytaert.