Basically, the heading says it.

To reproduce bug: Create a test site, add one product, add a product kit containing that product. Then enable cart links and enter /cart/add/p2 to add the product kit to the cart. Proceed to checkout. Only the billing address is shown, not the shipping address, because (it seems) the kit has been added as a non-shippable item.

Adding the product with Cart Links (/cart/add/p1) does not give the same problem.

CommentFileSizeAuthor
#6 441954.cart_link_kit_voodoo.2.x.patch1.01 KBcha0s

Comments

jamesoakley’s picture

jamesoakley
Primary language English
Location North Yorkshire, UK
commented

As a footnote, adding the product kit by visiting the node (/node/2), and clicking "Add to Cart" also gives no problems

jamesoakley’s picture

jamesoakley
Primary language English
Location North Yorkshire, UK
commented
Version: 6.x-2.0-rc1 » 6.x-2.0-rc2

just updating the version information to keep the issue queue up to date

jamesoakley’s picture

jamesoakley
Primary language English
Location North Yorkshire, UK
commented
Version: 6.x-2.0-rc2 » 6.x-2.0-rc3
Priority: Normal » Critical

Changed to critical.

Reflecting on this further: It's not critical for me, but only because I've spotted it and worked around it. To be unable to add product kits to the cart and then get a shipping quote is fairly critical for people who want to use cart links to promote things. (I can see Product Kits and Cart Links belonging very well together. You could do things like: Create a product kit with a product at a special discount, but not add that PK to the catalog; a cart link to purchase this could be sent out in a special offer e-mail.

Am I wrong to say this is a critical bug?

rszrama’s picture

rszrama commented
Priority: Critical » Normal

Well, it's certainly a bug, but critical bugs are usually show stoppers, database goofs, and crazy bad typos. This definitely needs to be fixed, but since it effects an extremely small percentage of Ubercart sites, I wouldn't normally call it critical. I will ping Lyle about it for you, though. ; )

jamesoakley’s picture

jamesoakley
Primary language English
Location North Yorkshire, UK
commented

Fair enough... :)

cha0s’s picture

cha0s commented
Assigned: Unassigned » cha0s
Status: Active » Needs review
StatusFileSize
new 441954.cart_link_kit_voodoo.2.x.patch1.01 KB

Need to fake FAPI values to make this work without many changes.

jamesoakley’s picture

jamesoakley
Primary language English
Location North Yorkshire, UK
commented
Status: Needs review » Reviewed & tested by the community

That works great. Thanks!

rszrama’s picture

rszrama commented
Status: Reviewed & tested by the community » Needs review
Issue tags: +ubercamp sprint
cha0s’s picture

cha0s commented

Why did you revert from reviewed and tested by the community to needs review? :(

rszrama’s picture

rszrama commented
Status: Needs review » Reviewed & tested by the community

Nooo clue. I don't remember doing it consciously, that's for sure. : P

Island Usurper’s picture

Island Usurper commented
Status: Reviewed & tested by the community » Fixed

Took me long enough to get to this one. Thanks, everybody. Committed.

Status: Fixed » Closed (fixed)
Issue tags: -ubercamp sprint

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +ubercamp sprint

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.