Hi there,

I noticed that the td under the select-all th has no class. This makes it difficult to theme.

In theme_privatemsg_list(), could you replace:

$data[] = drupal_render($form['threads'][$thread_id]);

with:

$data[] = array('data' => drupal_render($form['threads'][$thread_id]), 'class' => 'select-all');

?

Best,
Andrey.

CommentFileSizeAuthor
#3 privatemsg_select_class.patch888 bytesberdir

Comments

mr.andrey’s picture

mr.andrey commented

It also seems a bit odd to display "Subject" and "Last Updated" headings when there are no new messages.

Wouldn't it be better to just render the "no new messages" text by itself?

I can alter these things through template.php, but it seems to make sense to me to have them like that as default.

Best,
Andrey.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

I agree with the class, could you create a patch for that?
http://drupal.org/patch/create

However, I think displaying the message inside the table makes sense, core also does that at admin/content/node.

Also, keep in mind that the "empty" message is also displayed if you filter the messages and there are no "matches".

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Active » Needs review
StatusFileSize
new privatemsg_select_class.patch888 bytes

I choose the class name privatemsg-list-select, to have it prefixed and it's not a select all, just a select :)

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Version: 6.x-1.x-dev » 7.x-1.x-dev
Status: Needs review » Fixed

Fixed in 6.x-1.x-dev and 7.x-1.x-dev. Note that I accidentally committed some changes to privatemsg.module to fix D7 compatibility because of a fapi change in http://drupal.org/cvs?commit=264312.

For the reference, D7 now requires function($form, &$form_state, $more_args) when you use drupal_get_form() with additional params.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.