Over on #440788-3: Patch for 3 small errors - $id, get_filters(), and apachesolr_modify_query/OG problem I identifying a problem with the apachesolr_block() function. It calls $query->get_available_sorts() but that function isn't part of the Drupal_Solr_Query_Interface interface. This causes problems for the apachesolr_views module because the apachesolr_views_query class extends views_plugin_query and can't extend Solr_Base_Query. It seems to me that apachesolr_block() should either not call a function that's not part of the interface or it should be added to the interface.

Comments

pwolanin’s picture

@drewish - probably should be added to the interface - still working on making that sort-related code more robust.

Scott Reynolds’s picture

StatusFileSize
new2.09 KB

purposed solution. In general public functions should be in the interface unless it is specific to the search_api implementation

Scott Reynolds’s picture

Status: Active » Needs review

not sure whats going on with comments all of a sudden. Might be me but weird. plz review

pwolanin’s picture

StatusFileSize
new2.28 KB

That patch didn't apply for some reason.

Here's another version with some expanded code comments.

pwolanin’s picture

Status: Needs review » Fixed

committed to 6.x

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.