Fixes for a couple items I've found that cause ubercart to fail validation.

One note: The change from div to span for uc_price is for block views. When you display price as a field it outputs as a div inside of a span. Changing uc_price to span solves this and doesn't seem to have any adverse effect on the catalog.

CommentFileSizeAuthor
#6 span_price_theme.patch10.35 KBIsland Usurper
ubercart-validationtweaks.patch2.21 KBedegro

Comments

edegro’s picture

edegro commented
Status: Active » Needs review
rszrama’s picture

rszrama commented

Yep, the cart block fix needs to happen... was a relic from when I changed that to a background-image instead of an img tag. As for the price theming, gonna have Lyle chime in on what making that a div will do.

Island Usurper’s picture

Island Usurper commented

Could you explain where exactly the divs are rendered inside of a span? Is it the Views price field? I'd like to keep the theme as a div because it makes the product page look better.

rszrama’s picture

rszrama commented

fwiw, just looked at the payments tab, and having the price in a div looks yucky. I think I'm leaning toward the span, because really we don't know that every time a price is themed it should be a block level element. In fact, I think it would be much less so than an inline element, which would probably have allowed us to keep most of the prices as themed. : P

I can really only think of that one place on the product view page where it's in its own div, but then we may as well just put it in that one place in a wrapper (maybe it already is?).

edegro’s picture

edegro commented

It's when I create a block using Views2 with price as a field. More specifically I was getting:

<div class="views-field-sell-price">
<span class="field-content">
<div class="uc-price">$14.50</div>
</span>
</div>
Island Usurper’s picture

Island Usurper commented
StatusFileSize
new span_price_theme.patch10.35 KB

OK, I'm just working on the uc_price change at the moment. Remind me to go back to the other changes when I'm done if I don't do it on my own.

Since changing theme_uc_price() to use a span allows us to use the "themed" revision in more places, I've gone ahead and done that in this patch. I tended not to change the revision when uc_price() was used as a replacement value in t() because sites should have the freedom to put any kind of elements there that might not be appropriate in a sentence.

I've also reused theme_uc_product_price() in uc_product_view() to add the wrapping div around the price.

Island Usurper’s picture

Island Usurper commented
Status: Needs review » Fixed

OK, tested well, so all changes have been committed.

Thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.