While developping #371769: allow for n to n and typed user/client relationships, we noticed an inconsistency in the access controls for the site creation form that is in a tab of the Client node type. Basically, there are no access controls there. I can freely create a site for any Client as long as I'm logged in as a client that has the "create site" permission.

This obviously needs to be fixed before release.

CommentFileSizeAuthor
#3 client_access.patch838 bytesanarcat

Comments

anarcat’s picture

The problem is that there is not access check in the form itself. I confirm the issue by more formal testing: my "anarcat" user only has access to the "anarcat" client and was able to create a site in the "admin" client.

anarcat’s picture

Assigned: Unassigned » anarcat
anarcat’s picture

Assigned: anarcat » adrian
Status: Active » Needs review
StatusFileSize
new838 bytes

So here's my stab at this. I'm quite confused by all of this so I would appreciate adrian's eyeballs on this.

anarcat’s picture

Status: Needs review » Fixed

Fixed in my last commit. There was no access control on the form...

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.