If an exported node contains an object, the object will end up being imported as an array, and not only an array, but an array of arrays. This is probably not a good idea.

I've attached a patch which corrects this, and simplifies some of the import process.

PS: Looks like some whitespace fixes made it into the patch.

CommentFileSizeAuthor
node_export.patch3.37 KBcdale

Comments

danielb’s picture

danielb commented
Status: Needs review » Closed (works as designed)

The method used to generate the export code in that version of the module is absolutely out of date, sorry about this, but the method used to generate the code in the latest Drupal 5 version has proven to be the least buggy across different versions of PHP, and uses a much more manual process to build the export code, including keeping track of what is meant to be an object. I have fluffed something in CVS if the D6 does not have this...
My development copy seems to be up to date, I will get to this when I have a chance, as I've promised the node code would be consistent across Drupal versions.

danielb’s picture

danielb commented
Status: Closed (works as designed) » Active

oops

cdale’s picture

cdale commented

Yeah, looks like the 6.x-2.4 release has different code to the 5.x-2.1 release. If you could get this committed that would be tops.

danielb’s picture

danielb commented
Status: Active » Fixed

I've updated the node encoding in 6.x-2.5 to match the 5.x algorithm.
I'll deal with whitespace and code style down the track.

cdale’s picture

cdale commented

Cheers. :)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.