Something is not working correctly with my Theme Editor Install... When ever I am at: http://example.com/?q=admin/build/themes/editor/themename/ and click one of the drop downs on the right (example: Theme Info Files) the list will drop down. However when i select one of the files in this list to edit I am directed to: http://example.com/admin/build/themes/editor/themename/filetobeedited And them get a 404 Error!

The directory ./admin/build/themes/editor/themename/ did not exist. I created it and put the correct files in that directory. Then when I repeated the steps above the file would open as text (if it wasn't *.php of course).

Any thoughts?

CommentFileSizeAuthor
#3 theme_editor.patch1.68 KBarcaneadam

Comments

arcaneadam’s picture

arcaneadam commented

Yeah, the links weren't created originally to work without clean-urls. It was an oversight on my part and one that I have rectified, but have not had a chance to make the commit and push the update live.

I'll make the patch and commit it by this weekend so it will work on your site.

sjmccoy’s picture

sjmccoy commented

Any progress on the patch? I'm having the same issue.

arcaneadam’s picture

arcaneadam commented
Status: Active » Fixed
StatusFileSize
new theme_editor.patch1.68 KB

Here is the patch. I will commit it shortly into version 6-1.3( I think that is the version I would be on.)

sjmccoy’s picture

sjmccoy commented

Thanks for the quick response. Do I need to paste this code into theme_editor.inc?

sjmccoy’s picture

sjmccoy commented

Patch works!

In the themes_editor.inc file I deleted this code starting at line 687:

$li='

  • basename ? 'active_file' : '').''.($new == $val->basename ? ' new_file' : '').'" ref="'.$type.'">name.'/'.$val->basename.'" class="'.$file_img[$file_type].'">'.$val->basename.''.($new == $val->basename ? ' New' : '').'

    • ';

    and then replaced it with this code:

    $li='

  • basename ? 'active_file' : '').''.($new == $val->basename ? ' new_file' : '').'" ref="'.$type.'">'.l($val->basename.($new == $val->basename ? ' New' : ''),'admin/build/themes/editor/'.$theme->name.'/'.$val->basename, array('html'=>TRUE)).'

    • ';

    arcaneadam’s picture

    arcaneadam commented

    I would in the future read Applying Patches for more info on the proper way to apply a patch. Although the course of action you took worked, for a more complex patch it could be very tedious/error prone.

    sjmccoy’s picture

    sjmccoy commented

    Yeah, I did wonder if there was a better way to apply patches. Thanks for the link.

    Status: Fixed » Closed (fixed)

    Automatically closed -- issue fixed for 2 weeks with no activity.